Conversation
reinout
left a comment
reinout
left a comment
There was a problem hiding this comment.
Ik ga zelf wat uitzoekwerk doen :-)
| push: | ||
| branches: | ||
| - master | ||
| - main |
There was a problem hiding this comment.
I actually want to remove the whole test.yml, I accidentally left that one in. The basic nens-meta.yml covers a quick pytest call.
| [tool.ruff.lint.per-file-ignores] | ||
| "__init__.py" = ["F401", "F403"] |
There was a problem hiding this comment.
I'd prefer not to have it in the basic template. It is fine for properly build and maintained APIs, but advisors will also use this template and they have the tendency to make an unholy mess with import * in init files.
Easy to enable/add for individual projects that need it.
| [tool.pytest.ini_options] | ||
| addopts = "--cov --cov-fail-under=80" | ||
|
|
There was a problem hiding this comment.
Good one. I had forgotten that it breaks vscode.
A bummer, as this setting is a nice way to customise the waypytest runs in the github action without having to make changes to the generated gh action file.
There was a problem hiding this comment.
I'm adding a comment to mostly fix this: https://github.com/nens/cookiecutter-python-template/pull/25/files#diff-fc2fadee46a6a3ade3b8d0faee076978577745ccba23a0b1fb8f6483d0fa8b2c
| [project.optional-dependencies] | ||
| test = ["pytest>=8.4.2", "pytest-cov>=6.3.0", "pytest-sugar>=1.1.1"] | ||
|
|
There was a problem hiding this comment.
I need to do a bit of googling on this. I've automatically been using uv's install --dev, but I might need to change that.
|
Fixed in an alternative way in #25 |
2 participants
install -e .[test]devtotestto match the GH action--covpytest options because it breaks VS Code Python extension__init__files (F401/F403), because that is the way we define public API's (combined with an__all__= [stuff you want to expose]` in the modules