Open
Conversation
lbeschastny
reviewed
Mar 9, 2026
Comment on lines
+60
to
+63
| aws-config = { version = "=1.8.15", features = ["behavior-version-latest"] } | ||
| aws-sdk-appconfigdata = { version = "=1.96.0", features = ["test-util"] } | ||
| aws-sdk-dynamodb = "=1.108.0" | ||
| aws-smithy-mocks = "=0.2.6" |
lbeschastny
reviewed
Mar 9, 2026
Comment on lines
+41
to
+52
| aws-types = { version = "=1.3.14", optional = true } | ||
| aws-smithy-async = { version = "=1.2.14", optional = true } | ||
| aws-smithy-types-convert = { version = "=0.60.14", features = ["convert-streams"], optional = true } | ||
| aws-sdk-dynamodb = { version = "=1.108.0", optional = true } | ||
| aws-sdk-firehose = { version = "=1.104.0", optional = true } | ||
| aws-sdk-sns = { version = "=1.97.0", optional = true } | ||
| aws-sdk-sqs = { version = "=1.96.0", optional = true } | ||
| aws-sdk-s3 = { version = "=1.125.0", optional = true } | ||
| aws-sdk-sagemakerruntime = { version = "=1.99.0", optional = true } | ||
| aws-sdk-secretsmanager = { version = "=1.102.0", optional = true } | ||
| aws-sdk-ssm = { version = "=1.107.0", optional = true } | ||
| aws-sdk-appconfigdata = { version = "=1.96.0", optional = true } |
Collaborator
There was a problem hiding this comment.
Pinning dependencies here will make the crate unusable
lbeschastny
reviewed
Mar 9, 2026
| use aws_smithy_mocks::{mock, mock_client}; | ||
|
|
||
| #[tokio::test] | ||
| async fn start_configuration_session_instrument_send_accepts_no_arguments() { |
Collaborator
There was a problem hiding this comment.
Those 2 tests do not look very useful to me.
They basically test the same contract we have in the type system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates AWS SDK dependencies to use the latest compatible major versions and adds new test utilities for
aws-sdk-appconfigdata. It also introduces comprehensive tests for the AppConfigData instrumentation middleware, improving reliability and test coverage.Dependency updates:
Cargo.toml(such asaws-sdk-s3,aws-sdk-sagemakerruntime,aws-sdk-secretsmanager,aws-sdk-ssm, andaws-sdk-appconfigdata) to use the latest compatible major version ("1"), making future upgrades easier and ensuring compatibility with the latest features and bug fixes.aws-sdk-appconfigdatawith thetest-utilfeature andaws-smithy-mocksas dev-dependencies to support mocking AWS SDK clients in tests.Testing improvements:
src/middleware/aws/instrumentation/fluent_builder/appconfigdata.rsthat usesaws-smithy-mocksto test the AppConfigData instrumentation middleware, including tests forstart_configuration_sessionand attribute extraction fromget_latest_configuration.