Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
When adding a label to a series of elements that will be grouped in tabs in the output, the labels are not included in the generated `.tabbed` div. eg ``` [role=tabbed-example label--enterprise-edition] ===== [role=include-with-tabname] ====== ``` This PR includes the `.labels` div as the first child of the `.tabbed` div and defines a margin for the labels div in this context.
Fixes an issue where the selector to add a label to the whole tabbed section needed to be more specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a 'dark mode' option for viewing docs pages.
There are essentially two components:
color-scheme: light dark;, which allows different styles to be defined and used for when the user's browser or system settings indicate that they prefer 'light' or 'dark' mode.The design system version has been updated to the latest, and color vars are taken from tokens in the design package.
Ideally all colors are defined in vars-light.css and vars-dark.css. There should be no hard-coded colors in other css files.
For this POC, a set of vars is defined in
vars-light.cssand an equivalent set are defined invars-dark.cssand prefixed with--dark. For example, the following vars are defined:To use these values in a css selector you would use:
It is probably better to define the
light-dark(...)values in a single vars.css file.