Merged
Conversation
HannesSandberg
added
team-cypher-operations
Hunterness
reviewed
Mar 17, 2026
Contributor
Hunterness
left a comment
Hunterness
left a comment
There was a problem hiding this comment.
Might want to add labels/some mention for when things were introduced in more places than just that one
Collaborator
renetapopova
left a comment
renetapopova
left a comment
There was a problem hiding this comment.
Hey @HannesSandberg, great work!
I've pushed some editorial updates, but could you please review them carefully to ensure I haven't changed the meaning of anything!
renetapopova
force-pushed
the
abac-part-four
branch
from
1f26632 to
b1f5529
Compare
HannesSandberg
commented
Mar 19, 2026
HannesSandberg
commented
Mar 19, 2026
Contributor
Author
HannesSandberg
left a comment
HannesSandberg
left a comment
There was a problem hiding this comment.
Thank you @renetapopova! A very nice editorial review :)
I found a few small things, do you want me to update those?
Contributor
Author
|
Oh, there also seems to be a failing test in the build. Apparently the config setting description must match the description in neo4j |
Collaborator
Yes, thank you, go ahead. |
HannesSandberg
commented
Mar 19, 2026
Hunterness
reviewed
Mar 19, 2026
renetapopova
force-pushed
the
abac-part-four
branch
from
65060e4 to
709ec33
Compare
Hunterness
reviewed
Mar 19, 2026
Contributor
Hunterness
left a comment
Hunterness
left a comment
There was a problem hiding this comment.
No new comments, but there are still 4 open ones in the last group.
renetapopova
force-pushed
the
abac-part-four
branch
from
408a4e4 to
a2b8086
Compare
Hunterness
reviewed
Mar 20, 2026
renetapopova
force-pushed
the
abac-part-four
branch
from
a2b8086 to
cae0dcb
Compare
Collaborator
|
The fix for the failed test will be merged in 2026.04. |
fix code block add link added that SHOW commands and alter commands are not supported yet. updates to grant/revoke section in the ABAC page fix heading Update modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc add a temporal example Play-day review suggestions Play-day review suggestions Apply suggestions Play-day review suggestions Play-day review suggestions contd review fixes Re-add and fix stuff after the rebase review fixes review fix
review fixes document OR REPLACE review fixes Apply suggestions from code review Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
…d-access-control.adoc Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
renetapopova
force-pushed
the
abac-part-four
branch
from
9fe7ebe to
ce3e84b
Compare
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Hunterness
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #2879