Skip to content

Improve HTTP integration tests for database name parsing#274

Open
keremgocen wants to merge 13 commits into
2.xfrom
keremgocen/integration-tests-for-db-name-parsing
Open

Improve HTTP integration tests for database name parsing#274
keremgocen wants to merge 13 commits into
2.xfrom
keremgocen/integration-tests-for-db-name-parsing

Conversation

@keremgocen

@keremgocen keremgocen commented Apr 22, 2026

Copy link
Copy Markdown
Contributor
  • Adds database name validation (HTTP) integration tests and cleans up method restriction ones
  • Tests full chain with real DB via path /db/neo4j/mcp
  • Some refactor of integration tests; replaced global dbs with singleton, moved StartHTTPServer into helpers.go, deleted the long-running TestServerLifecycle (which is covered in e2e and unit tests already)
  • We now call cfg.Validate() in HTTP integration test setup config

In addition to tests;

  • buildQueryOptions is also simplified, no longer returns an error
  • Added empty dbName guard in the context getter

@keremgocen keremgocen marked this pull request as ready for review April 22, 2026 08:09
@keremgocen keremgocen requested a review from a team as a code owner April 22, 2026 08:09
@MacondoExpress

Copy link
Copy Markdown
Contributor

Can you split this PR in some smaller one? it's hard to follow the indirect reason of the changes as they are not scoped.
For instance I would add:
-Simply buildQueryOptions
-Add database name guard
and so on.. It will reduce the cognitive complexity for the reviewers, and it will reduce the time-to-merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants