Skip to content

Add convenience for Neo4j results#119

Merged
FlorentinD merged 10 commits intomainfrom
simplify-neo4j-viz
Mar 28, 2025
Merged

Add convenience for Neo4j results#119
FlorentinD merged 10 commits intomainfrom
simplify-neo4j-viz

Conversation

@FlorentinD
Copy link
Collaborator

No description provided.

@FlorentinD FlorentinD requested a review from Copilot March 28, 2025 11:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds convenience functions for converting Neo4j query results into visualization graphs and updates testing infrastructure to support both local and cloud-based Neo4j setups with GDS. Key changes include:

  • A new Docker Compose configuration for a Neo4j instance with GDS.
  • New tests for verifying the conversion of Neo4j query results.
  • An updated conversion function, from_neo4j, that processes both neo4j.graph.Graph and neo4j.Result objects.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test-envs/neo4j-gds/compose.yml Adds a new Docker Compose setup for Neo4j with GDS for testing.
python-wrapper/tests/test_neo4j.py Introduces tests for visualizing Neo4j query results.
python-wrapper/tests/test_gds.py Removes Python 3.13 skip markers for GDS integration tests.
python-wrapper/tests/conftest.py Enhances Neo4j and GDS fixtures with cloud and local options.
python-wrapper/src/neo4j_viz/neo4j.py Adds the from_neo4j function to create VisualizationGraph objects.
python-wrapper/pyproject.toml Updates dependency list to include neo4j.
python-wrapper/README.md Documents new support for Neo4j query results.
CONTRIBUTING.md Provides updated instructions for starting local Neo4j tests.
Files not reviewed (1)
  • docs/source/api-reference/from_neo4j.rst: Language not supported

Copy link
Collaborator

@adamnsch adamnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I see two things missing though:

  • A test where neo4j.Result is the input
  • A new docs session about the importer in integration.rst

FlorentinD and others added 4 commits March 28, 2025 14:50
Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
@FlorentinD FlorentinD merged commit f9b62ef into main Mar 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants