Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds convenience functions for converting Neo4j query results into visualization graphs and updates testing infrastructure to support both local and cloud-based Neo4j setups with GDS. Key changes include:
- A new Docker Compose configuration for a Neo4j instance with GDS.
- New tests for verifying the conversion of Neo4j query results.
- An updated conversion function, from_neo4j, that processes both neo4j.graph.Graph and neo4j.Result objects.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test-envs/neo4j-gds/compose.yml | Adds a new Docker Compose setup for Neo4j with GDS for testing. |
| python-wrapper/tests/test_neo4j.py | Introduces tests for visualizing Neo4j query results. |
| python-wrapper/tests/test_gds.py | Removes Python 3.13 skip markers for GDS integration tests. |
| python-wrapper/tests/conftest.py | Enhances Neo4j and GDS fixtures with cloud and local options. |
| python-wrapper/src/neo4j_viz/neo4j.py | Adds the from_neo4j function to create VisualizationGraph objects. |
| python-wrapper/pyproject.toml | Updates dependency list to include neo4j. |
| python-wrapper/README.md | Documents new support for Neo4j query results. |
| CONTRIBUTING.md | Provides updated instructions for starting local Neo4j tests. |
Files not reviewed (1)
- docs/source/api-reference/from_neo4j.rst: Language not supported
adamnsch
approved these changes
Mar 28, 2025
Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
66ae822 to
ee1150b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.