Move non-NVL custom fields into a properties dict#137
Conversation
adamnsch
force-pushed
the
entity_properties
branch
from
c9ce0b5 to
eac656b
Compare
Only `Node`, `Relationship` and `from_neo4j` updated so far. Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
adamnsch
force-pushed
the
entity_properties
branch
from
eac656b to
9763371
Compare
adamnsch
force-pushed
the
entity_properties
branch
from
f77c741 to
f8b121c
Compare
adamnsch
changed the title
|
|
||
|
|
||
| class PropertyType(Enum): | ||
| class ColorSpace(Enum): |
There was a problem hiding this comment.
I think I would prefer ValueSpace over ColorSpace.
Could at some doc string to clarify what we mean here
There was a problem hiding this comment.
I prefer ColorSpace as it also describes how one should interpret the colors provided to color_nodes. And a field/property can have float values, but you still might want to color it with a discrete space
There was a problem hiding this comment.
But yes, we should add doc strings
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
I like this change!
Its a good step allowing us other features we planned such as case-insensitive on data input :)
|
|
||
| def from_dfs( | ||
| node_dfs: DFS_TYPE, rel_dfs: DFS_TYPE, node_radius_min_max: Optional[tuple[float, float]] = (3, 60) | ||
| def _from_dfs( |
There was a problem hiding this comment.
why the 2 methods now? the signature looks the same?
There was a problem hiding this comment.
No they're not exactly the same. See the rename_properties arg, and how the from_gds loader uses it
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
2 participants
Thank you for your contribution to the Graph Data Science Client project.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: