Merged
Conversation
FlorentinD
reviewed
May 5, 2025
FlorentinD
approved these changes
May 5, 2025
Collaborator
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
I like it as a start :)
adamnsch
requested changes
May 7, 2025
Collaborator
adamnsch
left a comment
adamnsch
left a comment
There was a problem hiding this comment.
Very nice work! 🎉
I think we should remove the white background under the buttons though:
And I think some top and left margin would be good so that they're not pushed against the edge of the viz.
I have some other ideas for improvements, but those can wait I think :)
adamnsch
approved these changes
May 7, 2025
Collaborator
adamnsch
left a comment
adamnsch
left a comment
There was a problem hiding this comment.
This looks great! I would probably make the buttons a bit smaller too, but we can do that in a future PR too :)
adamnsch
force-pushed
the
add-screenshot-button
branch
from
a30b045 to
e67c4d6
Compare
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
adamnsch
force-pushed
the
add-screenshot-button
branch
from
30a884c to
d2f2c2a
Compare
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add buttons to take a screenshot and to zoom in and out. All buttons match Neo4j design guidelines as close as possible.
Example: