Skip to content

Fix CI issues #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorentinD merged 2 commits into from
May 9, 2025
Merged

Fix CI issues #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b992c
Support latest gds client version
FlorentinD May 9, 2025
4cc7455
Update dependencies for js applet
FlorentinD May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python-wrapper/src/neo4j_viz/resources/nvl_entrypoint/base.js
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 16 additions & 5 deletions python-wrapper/tests/gds_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import os

from graphdatascience import GraphDataScience
from graphdatascience.semantic_version.semantic_version import SemanticVersion
from graphdatascience.session import DbmsConnectionInfo, SessionMemory
from graphdatascience.session.aura_api import AuraApi
from graphdatascience.session.aura_api_responses import InstanceCreateDetails
from graphdatascience.version import __version__

GDS_VERSION = SemanticVersion.from_string(__version__)


def connect_to_plugin_gds(uri: str) -> GraphDataScience:
Expand All @@ -15,11 +19,18 @@ def connect_to_plugin_gds(uri: str) -> GraphDataScience:


def aura_api() -> AuraApi:
return AuraApi(
client_id=os.environ["AURA_API_CLIENT_ID"],
client_secret=os.environ["AURA_API_CLIENT_SECRET"],
tenant_id=os.environ.get("AURA_API_TENANT_ID"),
)
if GDS_VERSION >= SemanticVersion(1, 15, 0):
return AuraApi(
client_id=os.environ["AURA_API_CLIENT_ID"],
client_secret=os.environ["AURA_API_CLIENT_SECRET"],
project_id=os.environ.get("AURA_API_TENANT_ID"),
)
else:
return AuraApi(
client_id=os.environ["AURA_API_CLIENT_ID"],
client_secret=os.environ["AURA_API_CLIENT_SECRET"],
tenant_id=os.environ.get("AURA_API_TENANT_ID"), # type: ignore
)


def create_aurads_instance(api: AuraApi) -> tuple[str, DbmsConnectionInfo]:
Expand Down