Consider all field aliases in convenience constructors#165
Merged
Conversation
adamnsch
force-pushed
the
case-insensitive-continued
branch
2 times, most recently
from
3507ea2 to
424fe12
Compare
adamnsch
force-pushed
the
case-insensitive-continued
branch
from
424fe12 to
c756fc9
Compare
FlorentinD
approved these changes
May 19, 2025
Comment on lines
+100
to
+110
| def all_validation_aliases(exempted_fields: Optional[list[str]] = None) -> set[str]: | ||
| if exempted_fields is None: | ||
| exempted_fields = [] | ||
|
|
||
| by_field = [ | ||
| v.validation_alias.choices # type: ignore | ||
| for k, v in Relationship.model_fields.items() | ||
| if k not in exempted_fields | ||
| ] | ||
|
|
||
| return {str(alias) for aliases in by_field for alias in aliases} |
Collaborator
There was a problem hiding this comment.
nit. could be nice to have a test
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Graph Visualization for Python project by Neo4j.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: