gds/rel properties

[FlorentinD]

No description provided.

[adamnsch]

Nice! But I think we should still provide the opportunity to not fetch any properties. I would add a relationship_properties: Optional[list[str]] = None argument. None means we fetch everything, and [] means we fetch nothing

[adamnsch]

Nice! But I think we should still provide the opportunity to not fetch any properties. I would add a relationship_properties: Optional[list[str]] = None argument. None means we fetch everything, and [] means we fetch nothing

I suppose GDS only supports having one rel prop, so could even be a boolean 🤷

[FlorentinD]

@adamnsch the GDS graph can have multiple relationship types -- multiple rel properties.
Also some algorithms produce multiple properties. And at last, you can project multiple properties to a relationship.

[FlorentinD]

#173 (review)

for node-properties we default to no properties if additional_node_properties is not given.
Should we stick to the logic?
I was also confused now by the prefix additional. They are all from the projected graph.
I would have thought additional gets sources from the db and the others from GDS

[adamnsch]

@adamnsch the GDS graph can have multiple relationship types -- multiple rel properties. Also some algorithms produce multiple properties. And at last, you can project multiple properties to a relationship.

I thought for sure it was only possible to have one relationship property per relationship type. But ok!

[adamnsch]

#173 (review)

for node-properties we default to no properties if additional_node_properties is not given. Should we stick to the logic? I was also confused now by the prefix additional. They are all from the projected graph. I would have thought additional gets sources from the db and the others from GDS

I think "additional" refers to "in addition to the size_property that is already fetched". But yes, we might want to rethink the API now that we have the on-hover support. Maybe something we can discuss on Friday?

[adamnsch]

Nice! But I think we should still provide the opportunity to not fetch any properties. I would add a relationship_properties: Optional[list[str]] = None argument. None means we fetch everything, and [] means we fetch nothing

I suppose GDS only supports having one rel prop, so could even be a boolean 🤷

Actually never mind this, let's just fetch everything