Allow entities with different property sets in from_gds loader#189
Allow entities with different property sets in from_gds loader#189FlorentinD merged 4 commits intomainfrom
from_gds loader#189Conversation
| @@ -79,24 +79,31 @@ def from_gds( | |||
| """ | |||
There was a problem hiding this comment.
Should we also allow additional_node_properties to be given as a dict: label -> properties, and similarly size_property as dict: label -> property?
It would make things even more heterogeneous-native I think. But something for another PR
There was a problem hiding this comment.
i think there is a tradeoff in how difficult the api looks for first-users.
I think for such cases, you could always modify the visualization graph after initial import
| has_size &= "size" in node_df.columns | ||
| for _, row in node_df.iterrows(): | ||
| if dropna: | ||
| row.dropna(inplace=True) |
There was a problem hiding this comment.
These probably should not be inplace actually
There was a problem hiding this comment.
why not?
as mentioned in the other PR, you could also just skip the entry in the k,v loop below
There was a problem hiding this comment.
why not?
Since I don't think we want to modify the dataframes the user gives us, right?
as mentioned in the other PR, you could also just skip the entry in the k,v loop below
I think it's bit cleaner to do it like this :)
There was a problem hiding this comment.
right in pandas they come from the user. was mainly thinking from_gds here
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
|
Removed the |
|
|
||
| # setting as environment variables to run notebooks with this connection | ||
| os.environ["NEO4J_URI"] = dbms_connection_info.uri | ||
| assert isinstance(dbms_connection_info.username, str) |
There was a problem hiding this comment.
right latest gds release changed this.
There is dbms_connection_info.get_auth(), but thats not useful here to set an env variable
2 participants
Thank you for your contribution to the Graph Visualization for Python project by Neo4j.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure:
Based on #188