Conversation
| height, | ||
| ) | ||
|
|
||
| def resize_nodes(self, sizes: dict[NodeIdType, NodeSizeType]) -> None: |
There was a problem hiding this comment.
how about allow a simple scalar here as well?
Thinking of the nodes are too small or tiny.
The range-scaling we do during loading using pandas.
Passing a whole dict is very verbose isnt it?
There was a problem hiding this comment.
Yeah I thought about that too. But if some nodes are missing from the dict, they will use their old size. So scaling the dict would not be enough. And then we would have to scale all the node objects instead. We could do that but we've refrained from doing that in the past since we'd have to iterate through all of them
There was a problem hiding this comment.
i would say its fine to iterate through all for this case. What I would refrain from doing is more complicated multi-step computations for this method.
There was a problem hiding this comment.
Ok, I'll see what I can do 👍
There was a problem hiding this comment.
Done now, and added some more thorough error handling
adamnsch
force-pushed
the
resize-nodes
branch
from
8e5446e to
cb8c426
Compare
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
adamnsch
force-pushed
the
resize-nodes
branch
from
cb8c426 to
abb6049
Compare
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
2 participants
Thank you for your contribution to the Graph Data Science Client project.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: