Skip to content

WIP update nvl #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorentinD merged 6 commits into from
Feb 24, 2025
Merged

WIP update nvl #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d29bd5
WIP update nvl
FlorentinD Feb 21, 2025
248cf32
Update NVL dependency + rerun notebooks for docs
FlorentinD Feb 21, 2025
2aa79e3
Format getting started notebook
FlorentinD Feb 21, 2025
850cde9
Update base.js
FlorentinD Feb 21, 2025
2ea8043
Try using new options to improve rendering
FlorentinD Feb 21, 2025
20faceb
Fix nvl dependency
FlorentinD Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 17 additions & 82 deletions docs/extra/getting-started.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

50 changes: 25 additions & 25 deletions examples/gds-nvl-example.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions js-applet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nvl-python-wrapper",
"version": "0.3.6",
"version": "0.3.6-800b1623",
"scripts": {
"build": "webpack",
"postbuild": "cp dist/base.js ../python-wrapper/src/neo4j_viz/resources/nvl_entrypoint"
Expand All @@ -14,7 +14,7 @@
"webpack-cli": "^5.0.0"
},
"dependencies": {
"@neo4j-nvl/base": "^0.3.6",
"@neo4j-nvl/interaction-handlers": "^0.3.6"
"@neo4j-nvl/base": "0.3.6-02e96ab6",
"@neo4j-nvl/interaction-handlers": "0.3.6-02e96ab6"
}
}
3 changes: 2 additions & 1 deletion js-applet/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ class PyNVL {
options: NvlOptions = {},
callbacks = {}
) {
this.nvl = new NVL(frame, nvlNodes, nvlRels, { ...options, disableTelemetry: true }, callbacks)

this.nvl = new NVL(frame, nvlNodes, nvlRels, { ...options, disableTelemetry: true, disableWebWorkers: true, disableAria: true }, callbacks)
this.zoomInteraction = new ZoomInteraction(this.nvl)
this.panInteraction = new PanInteraction(this.nvl)
this.dragNodeInteraction = new DragNodeInteraction(this.nvl)
Expand Down
2 changes: 1 addition & 1 deletion python-wrapper/src/neo4j_viz/resources/nvl_entrypoint/base.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions scripts/makestyle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ if [ "${SKIP_NOTEBOOKS:-false}" == "true" ]; then
fi

python "${GIT_ROOT}/scripts/clean_notebooks.py" -i "${GIT_ROOT}/examples/" -o inplace
python "${GIT_ROOT}/scripts/clean_notebooks.py" -i "${GIT_ROOT}/docs/extra/" -o inplace