FEATURE: RedirectAdministrator works as single permission#81
Open
markusguenther wants to merge 1 commit intoneos:mainfrom
Open
FEATURE: RedirectAdministrator works as single permission#81markusguenther wants to merge 1 commit intoneos:mainfrom
markusguenther wants to merge 1 commit intoneos:mainfrom
Conversation
Make that users with just the role RedirectAdministrator can access the backend to be able to create redirects. Fixes: neos#80
Sebobo
reviewed
Oct 6, 2021
| privileges: | ||
| - privilegeTarget: 'Neos.Neos:Backend.GeneralAccess' | ||
| permission: GRANT | ||
| - privilegeTarget: 'Neos.RedirectHandler.Ui:Backend.Module.Management' |
Member
There was a problem hiding this comment.
Why not simply use Neos.Neos:Backend.Module.Management here instead of a new custom privilege target?
Member
Author
There was a problem hiding this comment.
Tried that but that did not work 🤷♂️
Member
There was a problem hiding this comment.
What happened when you did?
Did you also adjust the redirect after login setting for Neos?
Member
There was a problem hiding this comment.
I recommend using Neos.Neos:Backend.Module.Management and Neos.Neos:Backend.GeneralAccess and that should work.
Sebobo
requested changes
Jan 31, 2023
Member
Sebobo
left a comment
There was a problem hiding this comment.
We should use the default privileges instead of adding a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make that users with just the role RedirectAdministrator can access the backend to be able to create redirects.
redirect-admin.mp4
Fixes: #80