chore(nix): finish the -kit rename in the camelCase locals - #10
Merged
Conversation
The package rename landed everywhere the literal string `cl-prolog` / `cl-dataflow` appeared, but flake.nix names its let-bindings in camelCase -- clPrologWeaveSystem, clDataflowSource, clDataflowPackage -- and those spellings contain no hyphen, so neither the substitution nor the residual grep that checked it ever saw them. The verification was written from the same pattern list as the edit, so it confirmed exactly the cases that had been considered and stayed silent on this one. Purely a binding-name change: every value these names hold already pointed at the renamed input and the renamed .asd, and CI was green before this commit. Nothing functional changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
-kitrename.flake.nixnames itslet-bindings in camelCase (clPrologWeaveSystem,clDataflowSource,clDataflowPackage), which contain no hyphen — so neither the original substitution nor the residual grep that checked it ever matched them.Why it was missed: the verification grep was built from the same pattern list as the edit, so it confirmed exactly the spellings that had been considered and was silent on the one that had not.
Impact: none. Every value these bindings hold already pointed at the renamed input and the renamed
.asd, and CI was green before this commit. This is a naming-consistency change only.