fix: honour screen-blit's :width and :height arguments - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screen-blitaccepted, validated, declared and then never used its:widthand:heightarguments — the clip bounds derived only from the source and destination extents. A bounded blit therefore copied the whole overlap instead of the requested region, contradicting the docstring.Consumers are affected: cl-asciiquarium's incremental renderer expressed its entire right/bottom clip through exactly these two arguments, so it painted outside the region it had cleared.
The clamp applies only when the caller actually supplied the argument. An omitted one still means "the whole source" — clamping by its default as well truncated a negative
:src-xcopy, which an earlier revision of this branch did and a regression test now pins.Verification:
nix flake checkexit 0, 1696 passed / 0 failed.