fix: use ASCII record separator for multiline draft content in queries#1
Open
tofagerl wants to merge 1 commit intonerveband:mainfrom
Open
fix: use ASCII record separator for multiline draft content in queries#1tofagerl wants to merge 1 commit intonerveband:mainfrom
tofagerl wants to merge 1 commit intonerveband:mainfrom
Conversation
The list/query command uses newline as a record separator between drafts in the AppleScript output, but draft content can itself contain newlines. This causes parseDraftFromAppleScript to split records mid-content, silently dropping or garbling any draft with multiline content. Switch to ASCII Record Separator (0x1E) which won't appear in user-authored text. Includes a regression test that creates a multiline draft and verifies Query returns it with content intact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list/Querysilently drops or garbles any draft whose content contains newlines, becausequeryDraftsuses\nas both the record separator between drafts and it appears verbatim in multi-line contentlinefeedtoASCII character 30(Record Separator,0x1E) — a control character designed for this purpose that won't appear in user-authored textTestQueryMultilineContentwhich creates a multi-line draft, queries for it, and verifies both discovery and content integrityHow to reproduce the bug
drafts get <uuid>works fine because it queries a single draft without using newline as a record separator.Test plan
TestQueryMultilineContentfails onmain, passes with fixTestWorkspacesfails, pre-existing)🤖 Generated with Claude Code