Fix snes rumble controller#83
Open
undisbeliever wants to merge 2 commits intonesdev-org:masterfrom
Open
Conversation
The rumble controller spec document states the 16-bit shift register should be cleared when the P/S Out line goes high and then low. This behaviour has been verified on a Limited Run Games rumble controller with a custom test ROM. https://forums.nesdev.org/viewtopic.php?t=26602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 bugs in Mesen's implementation of the LRG rumble controller.
_rumbleDataafter setting force-feedback.This behaviour is discovered by a new test ROM I wrote that was tested by NovaSquirrel (nesdev forum post with 2 test ROMs). I wrote the test because Mesen, SNES_Mister and the rumble controller spec doc have different behaviour regarding rumble controller latching.
The second commit fixes the second bug in a hacky way. It uses
SnesRumbleController::RefreshStateBuffer()as a timer callback as I did not want to add a rumble stop timeout toKeyManagerand potentially break the game boy rumble.These commits have been testing by: