NES: FDS Accuracy Improvements#85
Draft
TakuikaNinja wants to merge 11 commits intonesdev-org:masterfrom
Draft
Conversation
Passes latest FDS-Mirroring-Test Disk registers behave closer to hardware in FDS-4023-Test
$4023.D0 = 0 forces output to $7F Always return good battery status in $4033.D7
Modulation has unfortunately regressed
- Fix GetModIncrement() - Optimise mod counter register display - Add disable logic in UpdateCounter() for now fixme: Modulation issues in FDS-Audio-Registers and Bio Miracle Bokutte Upa
Eventually needed by Tonkachi Editor, though it still fails to access disks for editing
Fixes modulation in FDS-Audio-Registers Also remove redundant TickEnvelope definition
Author
|
Turns out the PR I was referencing for the modulation had missed the fact that the mod accumulator is halted while $4087.D7 = 1. FDS-Audio-Registers sounds correct now. Bio Miracle Bokutte Upa still sounds weird compared to recordings I found on TCRF, however, so I'll have to double check against my Twin Famicom. Maybe the mixing resistor swap will make it easier to discern! 😛 |
Author
|
Scaling back the scope of this PR a bit - the remaining register view changes will go into a separate PR, and register peeking will have to wait until more accuracy improvements have been made. Note: The audio debug registers ($4090-$4097) have already been added to the register viewer under an appropriate heading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the FDS accuracy based on ongoing research: https://www.nesdev.org/wiki/User:TakuikaNinja/FDS_Registers
I'm not as familiar with the audio side of things, so any help there would be appreciated.
Working
Needs testing/fixing
Not addressing
_soundRegEnabledto reflect its purposeTest programs