Skip to content

NES: NINA-01/02 (NES 2.0 #34.1) oversized ROM support#97

Open
HeeminTV wants to merge 3 commits intonesdev-org:masterfrom
HeeminTV:nina0102_oversize_support
Open

NES: NINA-01/02 (NES 2.0 #34.1) oversized ROM support#97
HeeminTV wants to merge 3 commits intonesdev-org:masterfrom
HeeminTV:nina0102_oversize_support

Conversation

@HeeminTV
Copy link
Copy Markdown

@HeeminTV HeeminTV commented May 9, 2026

No description provided.

@HeeminTV HeeminTV changed the title NINA-01/02 (NES 2.0 #34.1) oversized ROM support NES: NINA-01/02 (NES 2.0 #34.1) oversized ROM support May 9, 2026
@asiekierka
Copy link
Copy Markdown

Should the MMC5 DAC commits be in this branch?

@HeeminTV
Copy link
Copy Markdown
Author

I don't think so...

@TakuikaNinja
Copy link
Copy Markdown

You'll have to rewrite the commit history to remove the MMC5 commits from that particular branch. In the future, please create branches from an unmodified branch when making PRs.

@HeeminTV
Copy link
Copy Markdown
Author

right. I forgot to do so (I think I've never made more than one PR in one repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants