Allocate exclusive per-container UID/GID blocks#78
Open
yaoxin-jing wants to merge 1 commit intonestybox:masterfrom
Open
Allocate exclusive per-container UID/GID blocks#78yaoxin-jing wants to merge 1 commit intonestybox:masterfrom
yaoxin-jing wants to merge 1 commit intonestybox:masterfrom
Conversation
Sysbox-CE currently maps all containers to the same host UID/GID range, meaning container root (UID 0) resolves to the same host user across all containers. This weakens isolation since a breakout from one container could access another container's files. Change Alloc() to hand out sequential, non-overlapping 65536-uid/gid blocks from the subordinate range. Each container ID gets its own block; repeated calls with the same ID return the existing allocation. Free() recycles blocks for reuse. Also increase subidRangeSize from 65536 to 268435456 so that configSubidRange() provisions enough subordinate IDs for up to 4096 concurrent containers (same capacity as Sysbox-EE). Signed-off-by: yaoxin jing <yaoxin19950517@gmail.com>
yaoxin-jing
force-pushed
the
exclusive-uid-alloc
branch
from
8e9111a to
eeaef30
Compare
Author
|
@ctalledo could you have a look on this patch. many thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sysbox-CE currently maps all containers to the same host UID/GID range, meaning container root (UID 0) resolves to the same host user across all containers. This weakens isolation since a breakout from one container could access another container's files.
Change Alloc() to hand out sequential, non-overlapping 65536-uid/gid blocks from the subordinate range. Each container ID gets its own block; repeated calls with the same ID return the existing allocation. Free() recycles blocks for reuse.
Also increase subidRangeSize from 65536 to 268435456 so that configSubidRange() provisions enough subordinate IDs for up to 4096 concurrent containers (same capacity as Sysbox-EE).