Open
Conversation
- Replace Travis CI with GitHub Actions workflow (ubuntu + macos) - Rewrite PANDA tests: epsilon-based float comparison, format validation, nonzero edge check (3 test cases) - Rewrite PUMA tests: epsilon-based float comparison, format validation, nonzero edge check, miRNA regulator check (4 test cases) - Add PUMA reference output for regression testing - Update reference PANDA output for cross-platform consistency - Fix PUMA test Makefile (wrong target name, remove -lncurses dep) - Update README badges from Travis CI to GitHub Actions
Add GitHub Actions CI and improve PANDA/PUMA tests
…Linux PUMA's REGULATION struct array with MAXTFS=1500 creates a ~2GB __DATA segment that exceeds the macOS Mach-O segment size limit, causing dyld to fail loading libc++.1.dylib/libSystem.B.dylib with exit code 134 (SIGABRT). Reducing MAXTFS and MAXMIRS to 1000 (matching PANDA) brings __DATA under the limit. Output is verified identical with the toy dataset reference.
Both PUMA.c and PANDA_v2.c are pure C code with no C++ features. Compiling with g++ on Ubuntu causes SIGABRT due to C++ runtime initialization issues with the ~2GB BSS segment. Using gcc avoids the C++ runtime overhead and resolves the crash on Linux.
Contributor
Author
|
@taraeicher please merge this as well, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge master back into devel to sync branches. Master is 7 commits ahead of devel, including the GitHub Actions CI workflow added in PR #53.