NAB-380 #28
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,105 +1,98 @@ | ||
| <div class="app-container"> | ||
| <mat-sidenav-container class="app-mat-sidenav-container"> | ||
| <mat-sidenav class="app-mat-viewnav" mode="side" disableClose="true" opened> | ||
| <a [href]="config.services.urls.netgrif" target="_blank" class="logo"> | ||
| <img src="../assets/netgrif_logo.svg" alt="Netgrif logo" class="main-toolbar-logo"> | ||
| </a> | ||
| <mat-action-list class="menu-items"> | ||
| <mat-list-item class="field-list-mat-list-item" | ||
| joyrideStep="{{tutorial.demo.step}}" | ||
| title="{{tutorial.demo.title}}" | ||
| text="{{tutorial.demo.text}}" | ||
| stepPosition="{{tutorial.demo.position}}" | ||
| (click)="openInTab(config.services.urls.engine)" | ||
| matTooltip="Netgrif Demo" matTooltipPosition="right"> | ||
| <mat-icon>play_arrow</mat-icon> | ||
| </mat-list-item> | ||
| <mat-list-item class="field-list-mat-list-item" | ||
| joyrideStep="{{tutorial.youtube.step}}" | ||
| title="{{tutorial.youtube.title}}" | ||
| text="{{tutorial.youtube.text}}" | ||
| stepPosition="{{tutorial.youtube.position}}" | ||
| (click)="openInTab(config.services.urls.youtube)" | ||
| matTooltip="Youtube Channel" matTooltipPosition="right"> | ||
| <mat-icon svgIcon="youtube"></mat-icon> | ||
| </mat-list-item> | ||
| <mat-list-item class="field-list-mat-list-item" | ||
| joyrideStep="{{tutorial.github.step}}" | ||
| title="{{tutorial.github.title}}" | ||
| text="{{tutorial.github.text}}" | ||
| stepPosition="{{tutorial.github.position}}" | ||
| (click)="openInTab(config.services.urls.github)" | ||
| matTooltip="Github" matTooltipPosition="right"> | ||
| <mat-icon svgIcon="github">device_hub</mat-icon> | ||
| </mat-list-item> | ||
| <mat-list-item class="field-list-mat-list-item" | ||
| joyrideStep="{{tutorial.mortgage.step}}" | ||
| title="{{tutorial.mortgage.title}}" | ||
| text="{{tutorial.mortgage.text}}" | ||
| stepPosition="{{tutorial.mortgage.position}}" | ||
| (click)="addMortgage()" | ||
| matTooltip="Mortgage demo" matTooltipPosition="right"> | ||
| <mat-icon>device_hub</mat-icon> | ||
| </mat-list-item> | ||
| </mat-action-list> | ||
| <mat-action-list class="app-viewnaw-bottom-list menu-items"> | ||
| <mat-list-item class="field-list-mat-list-item" | ||
| joyrideStep="{{tutorial.bug.step}}" | ||
| title="{{tutorial.bug.title}}" | ||
| text="{{tutorial.bug.text}}" | ||
| stepPosition="{{tutorial.bug.position}}" | ||
| (done)="tutorial.onClose()" | ||
| (click)="openInTab(config.services.urls.issues)" | ||
| matTooltip="Report a bug" matTooltipPosition="right"> | ||
| <mat-icon>bug_report</mat-icon> | ||
| </mat-list-item> | ||
| <mat-list-item class="field-list-mat-list-item" | ||
| (click)="help()" | ||
| matTooltip="Help" matTooltipPosition="right"> | ||
| <mat-icon>help</mat-icon> | ||
| </mat-list-item> | ||
| </mat-action-list> | ||
| </mat-sidenav> | ||
| <joyrideStep joyrideStep="{{tutorial.welcome.step}}" stepPosition="{{tutorial.welcome.position}}" | ||
| title="{{tutorial.welcome.title}}" text="{{tutorial.welcome.text}}" | ||
| (next)="tutorial.welcome.onNext()"></joyrideStep> | ||
| <mat-tab-group mat-stretch-tabs="false" mat-align-tabs="start" animationDuration="0ms" class="app-tabs" | ||
| [selectedIndex]="activeProcessIndex()" | ||
| (selectedTabChange)="changeTab($event)"> | ||
| <mat-tab disabled="true"> | ||
| <ng-template mat-tab-label> | ||
| <button mat-icon-button (click)="openApplicationDialog()"> | ||
| <mat-icon class="tab-icon" matTooltip="Application" style="color: rgba(0,0,0,0.6)!important;"> | ||
| app_registration | ||
| </mat-icon> | ||
| </button> | ||
| </ng-template> | ||
| </mat-tab> | ||
| @for (process of applicationService.models; track process[0]) { | ||
| <mat-tab label="{{process[0]}}"> | ||
| <ng-template mat-tab-label> | ||
| @if (process[1].icon) { | ||
| <mat-icon class="tab-icon">{{ process[1].icon }}</mat-icon> | ||
| } | ||
| {{ process[1].title.value }} [{{ process[1].id }}] | ||
| </ng-template> | ||
| </mat-tab> | ||
|
Comment on lines
+78
to
+86
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Find the applicationService and how models is defined
fd "\.ts$" | xargs rg -l "applicationService|class.*Service" | head -20Repository: netgrif/application-builder Length of output: 1088 🏁 Script executed: #!/bin/bash
# Check the switchActiveModel method signature and its usage
rg -n "switchActiveModel" --type ts -B 2 -A 5Repository: netgrif/application-builder Length of output: 3668 🏁 Script executed: #!/bin/bash
# Find where applicationService.models is used and how it's structured
rg -n "applicationService\.models" --type ts -B 2 -A 2Repository: netgrif/application-builder Length of output: 2712 🏁 Script executed: #!/bin/bash
# Find the models getter in application.service.ts
rg -n "get models" --type ts -A 15 src/app/project-builder/application.service.tsRepository: netgrif/application-builder Length of output: 486 🏁 Script executed: #!/bin/bash
# Also check how models is used in the component - does it iterate over entries?
cat -n src/app/app.component.html | sed -n '75,95p'Repository: netgrif/application-builder Length of output: 1101 Tab label mismatch breaks tab switching—textLabel does not match model ID format.
In Fix: Use 🤖 Prompt for AI Agents |
||
| } | ||
| <mat-tab disabled="true"> | ||
| <ng-template mat-tab-label> | ||
| <button mat-icon-button (click)="addNewEmptyModel()"> | ||
| <mat-icon>add</mat-icon> | ||
| </button> | ||
| </ng-template> | ||
| </mat-tab> | ||
| </mat-tab-group> | ||
| <router-outlet></router-outlet> | ||
| </mat-sidenav-container> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 480
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 102
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 203
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 174
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 5103
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 53
🏁 Script executed:
ls -la pnpm-lock.yaml 2>&1Repository: netgrif/application-builder
Length of output: 132
🏁 Script executed:
Repository: netgrif/application-builder
Length of output: 53
🏁 Script executed:
git log --all --oneline | head -5Repository: netgrif/application-builder
Length of output: 151
🏁 Script executed:
git show --stat 3c4b707 | head -30Repository: netgrif/application-builder
Length of output: 1620
Remove
pnpm-lock.yamlfrom.gitignoreto ensure reproducible builds.This project uses pnpm (evidenced by
pnpm-workspace.yaml), makingpnpm-lock.yamlthe lock file that should be committed to ensure all developers and CI environments use identical dependency versions. Ignoring it leads to non-reproducible builds and "works on my machine" issues.The
package-lock.jsonentry is appropriate to ignore since the project uses pnpm, not npm.🤖 Prompt for AI Agents