Fix duplicate NSWorkspaceDidWakeNotification observations#21
Open
davidme-stripe wants to merge 1 commit intonetik:masterfrom
Open
Fix duplicate NSWorkspaceDidWakeNotification observations#21davidme-stripe wants to merge 1 commit intonetik:masterfrom
davidme-stripe wants to merge 1 commit intonetik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I incorrectly added an observer to
NSWorkspaceDidWakeNotificationduring thescheduleTimerfunction. When showing seconds, this means that UTCMenuClock would re-register for the notification every second, and it would re-register observation that many times on each wake. This caused #20.Moving the observation to
awakeFromNibshould fix it. I also renamed the function to make it clearer that this should be only called once. Sorry for breaking it!