NETOBSERV-2609 show tls usage in topology view by jpinsonneau · Pull Request #1451 · netobserv/netobserv-web-console

jpinsonneau · 2026-04-22T11:33:33Z

Description

Display TLS versions and message types in topology side panel
Also display a lock with a green / yellow / red color showing if the TLS version involved is valid
Add an option to show an open lock when no TLS is involved

Dependencies

Based on #1478

Checklist

Does the changes in PR need specific configuration or environment set up for testing?
- if so please describe it in PR description.
I have added thorough unit tests for the change.
QE requirements (check 1 from the list):
- Standard QE validation, with pre-merge tests unless stated otherwise.
- Regression tests only (e.g. refactoring with no user-facing change).
- No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

openshift-ci · 2026-04-22T11:33:37Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-04-22T11:33:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-04-22T11:33:41Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: df811931-8e21-43d0-b663-658607a34ed8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-04-22T11:37:58Z

New image:

quay.io/netobserv/network-observability-console-plugin:fa4506a

It will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=fa4506a make set-plugin-image

codecov · 2026-04-22T11:38:04Z

Codecov Report

❌ Patch coverage is 64.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.31%. Comparing base (b905ded) to head (a46aa03).
⚠️ Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/handler/lokiclientmock/tls_matrix_inject.go	65.95%	8 Missing and 8 partials ⚠️
pkg/handler/lokiclientmock/loki_client_mock.go	0.00%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b905ded) and HEAD (a46aa03). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (b905ded) HEAD (a46aa03)

uitests 1 0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1451       +/-   ##
===========================================
- Coverage   52.47%   41.31%   -11.16%     
===========================================
  Files         233       46      -187     
  Lines       12438     3340     -9098     
  Branches     1559        0     -1559     
===========================================
- Hits         6527     1380     -5147     
+ Misses       5297     1774     -3523     
+ Partials      614      186      -428

Flag	Coverage Δ
uitests	`?`
unittests	`41.31% <64.00%> (+0.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/config/config.go	`47.76% <100.00%> (+0.39%)`	⬆️
pkg/handler/lokiclientmock/loki_client_mock.go	`0.00% <0.00%> (ø)`
pkg/handler/lokiclientmock/tls_matrix_inject.go	`65.95% <65.95%> (ø)`

... and 188 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jpinsonneau · 2026-04-22T14:19:11Z

@jotak can you please share how to generate deprecated TLS traffic ?

I tried some curl using TLS1.2 but the eBPF agents are not capturing it 😞

- Add 4 new overview panels related to TLS: - TLS global usage (traffic with/without TLS) - breakdown by version - breakdown by group - breakdown by cipher suite - Add new column filter "tls" in manage columns panel - Fix issues in logQL when querying on arrays: handle looking for field presence/absence - Refactoring: introduce StructuredFlowQuery, an intermediate data structure used before the flow query is entirely serialized for HTTP. It allows to keep and manipulate structured filters for complex queries.

- Simplify TLS usage donut to show just TLS vs Other (it's easier to achieve with prom metrics) - Show % of TLS rather than total Pps - Fix a couple of JS warnings

github-actions · 2026-05-11T09:28:58Z

New image:

quay.io/netobserv/network-observability-console-plugin:7bdb498

It will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7bdb498 make set-plugin-image

Donut legend will not be dispayed anymore when rendered on small screens. It's still available as a tooltip though.

jotak · 2026-05-11T10:07:38Z

+  if (!metricType) {
+    return false;
+  }
+  return (
+    metricType === 'Bytes' ||
+    metricType === 'Packets' ||
+    metricType === 'PktDropBytes' ||
+    metricType === 'PktDropPackets'
+  );


So, I think the way I'm changing the metrics here won't work that way. It would be a new query to run, with TlsFlows as the metric type

Sure, let me adapt to the new approach

jotak · 2026-05-11T10:11:11Z

In terms of graphical design it looks nice to me!
But the implementation will conflict with other changes that I'm doing, the tldr; is that I changed the approach, instead of adding TLS info into existing metrics, it's now a separate metric to fetch, much like what we're doing with DNS

* sdk + pf6 migration * data test ids * Add some more data-test ids * PF updates and styling fix * installDemoLoki & fullscreen issues * standalone theme * fix redirect after FlowCollector create * force update on CR change * fix cypress --------- Co-authored-by: Amoghrd <aramesha@redhat.com>

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>

openshift-ci · 2026-05-13T15:24:15Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jpinsonneau · 2026-05-13T15:24:45Z

Refactored based on #1478

Will rebased when merged and cherry picked on PF6 branch

jpinsonneau added 2 commits April 21, 2026 15:02

trigger image builds (netobserv#1446)

5f4a199

fix standalone build (netobserv#1447)

acc8a6f

openshift-ci Bot added the do-not-merge/work-in-progress label Apr 22, 2026

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 22, 2026

jpinsonneau force-pushed the 2609 branch from aeace0b to a13b1cc Compare April 22, 2026 14:19

github-actions Bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 22, 2026

jpinsonneau requested a review from jotak April 22, 2026 14:19

jotak added 2 commits May 5, 2026 15:26

Fix tls usage from prometheus

cb0da63

- Simplify TLS usage donut to show just TLS vs Other (it's easier to achieve with prom metrics) - Show % of TLS rather than total Pps - Fix a couple of JS warnings

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 11, 2026

Fix donut legend overlapping

a35f623

Donut legend will not be dispayed anymore when rendered on small screens. It's still available as a tooltip though.

jotak reviewed May 11, 2026

View reviewed changes

Comment thread web/src/api/ipfix.ts Outdated

jotak reviewed May 11, 2026

View reviewed changes

github-actions Bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 11, 2026

jpinsonneau and others added 3 commits May 11, 2026 14:33

Update Konflux references (netobserv#1442)

66ee47f

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>

show tls usage in topology view

2bb3f3e

jpinsonneau force-pushed the 2609 branch from a46aa03 to 2bb3f3e Compare May 13, 2026 15:24

openshift-ci Bot added the needs-rebase label May 13, 2026

jpinsonneau added the do-not-merge/hold label May 13, 2026

Conversation

jpinsonneau commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

codecov Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jpinsonneau commented Apr 22, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

Uh oh!

jotak May 11, 2026

Choose a reason for hiding this comment

Uh oh!

jpinsonneau May 11, 2026

Choose a reason for hiding this comment

Uh oh!

jotak commented May 11, 2026

Uh oh!

openshift-ci Bot commented May 13, 2026

Uh oh!

jpinsonneau commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpinsonneau commented Apr 22, 2026 •

edited

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited

Loading