NETOBSERV-2689: Update PF5 tests#1459
Open
Amoghrd wants to merge 6 commits into
Open
Conversation
Collaborator
|
@Amoghrd: This pull request references NETOBSERV-2689 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Amoghrd
force-pushed
the
update-pf5-tests
branch
from
528667d to
537b751
Compare
Amoghrd
changed the title
Amoghrd
force-pushed
the
update-pf5-tests
branch
from
537b751 to
5c1af34
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
web/src/components/metrics/histogram.tsx (1)
268-275:⚠️ Potential issue | 🟠 MajorAdd ARIA labels to icon-only histogram controls.
These buttons are icon-only; they need explicit accessible names. Tooltips alone are not sufficient for screen-reader labeling.
Proposed fix
<Button data-test="histogram-double-left" + aria-label={t('Shift histogram range left')} icon={<AngleDoubleLeftIcon />} variant="plain" className={`metrics-content-button ${loading ? 'loading' : ''}`} onClick={() => moveRange(false)} ref={arrowRef} /> @@ <Button data-test="histogram-single-left" + aria-label={t('Page histogram range left')} icon={<AngleLeftIcon />} variant="plain" className={`metrics-content-button ${loading ? 'loading' : ''}`} onClick={() => moveHistogramRange(false)} ref={pageRef} /> @@ <Button data-test="histogram-single-right" + aria-label={t('Page histogram range right')} icon={<AngleRightIcon />} variant="plain" className={`metrics-content-button ${loading ? 'loading' : ''}`} onClick={() => moveHistogramRange(true)} /> @@ <Button data-test="histogram-double-right" + aria-label={t('Shift histogram range right')} icon={<AngleDoubleRightIcon />} variant="plain" className={`metrics-content-button ${loading ? 'loading' : ''}`} onClick={() => moveRange(true)} /> @@ <Button data-test="histogram-zoom-out" + aria-label={t('Zoom out histogram')} icon={<SearchMinusIcon />} variant="plain" className={`metrics-content-button ${loading ? 'loading' : ''}`} onClick={() => zoomRange(false)} ref={zoomRef} /> @@ <Button data-test="histogram-zoom-in" + aria-label={t('Zoom in histogram')} icon={<SearchPlusIcon />} variant="plain" className={`metrics-content-button ${loading ? 'loading' : ''}`} onClick={() => zoomRange(true)} />As per coding guidelines, "Implement accessibility with ARIA labels and keyboard navigation in React components".
Also applies to: 282-289, 301-307, 314-320, 331-338, 347-353
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/metrics/histogram.tsx` around lines 268 - 275, The icon-only Buttons in histogram.tsx lack accessible names; add explicit aria-label attributes to each icon-only control (for example the Buttons with data-test="histogram-double-left", "histogram-left", "histogram-right", "histogram-double-right" and any other arrow/zoom Buttons) that describe the action (e.g., "Move range to start", "Move range left", "Move range right", "Move range to end"); keep the existing tooltip and className/refs/onClick (e.g., moveRange, arrowRef, loading) unchanged and ensure the aria-label is a clear, concise verb phrase so screen readers can announce the control.web/cypress/integration-tests/table_queryopts.cy.ts (1)
46-69:⚠️ Potential issue | 🟡 MinorDon't rely on
parseFloatfor compact counts.
parseFloat()only reads the leading numeric prefix, so values like1.5kor1,234collapse to the wrong number. If these summary metrics can render compact or localized formatting, this assertion stops validating the real count.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/cypress/integration-tests/table_queryopts.cy.ts` around lines 46 - 69, The test is using parseFloat on the summary metric texts (in the it block that checks query summary panel) which fails for compact/localized formats like "1.5k" or "1,234"; add a small parsing helper (e.g., parseCompactCount) that normalizes strings by removing thousands separators, handling suffixes like k/K, m/M, g/G (multiplying accordingly) and trimming plus signs, then use that helper in place of parseFloat when reading querySumSelectors.flowsCount, querySumSelectors.bytesCount and querySumSelectors.packetsCount so the assertions compare the true numeric values.web/cypress/integration-tests/netflow_zone_multiCluster.cy.ts (1)
23-25:⚠️ Potential issue | 🟠 MajorRegister the intercept before the scope change.
topologyPage.selectScopeGroup("resource", "owners")already runs inbeforeEach, so thiscy.intercept(...)is added after the request has gone out. The fixture will miss the call you are trying to stub.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/cypress/integration-tests/netflow_zone_multiCluster.cy.ts` around lines 23 - 25, The intercept for the network call must be registered before the scope change so the fixture can stub the request; move the cy.intercept(...) that stubs the topology request into the setup that runs before topologyPage.selectScopeGroup("resource", "owners") (e.g. the beforeEach or immediately before calling selectScopeGroup), ensuring the stub is active before the request fires; keep references to cy.intercept, topologyPage.selectScopeGroup("resource","owners"), and cy.openColumnsModal()/colSelectors.columnsModal so you can locate and update the test code.web/cypress/views/netobserv.ts (1)
122-135:⚠️ Potential issue | 🟠 MajorFail fast when the FlowCollector link is missing.
The new
if (href)guard turns a broken selector into a silent no-op, so the test can keep running on the wrong page. Assert the link exists before visiting it.Suggested fix
- cy.get(selector).invoke('attr', 'href').then(href => { - if (href) { - cy.visit(href) - } - }) + cy.get(selector) + .should('have.attr', 'href') + .invoke('attr', 'href') + .then(href => cy.visit(href)) @@ - cy.contains('Flow Collector').invoke('attr', 'href').then(href => { - if (href) { - cy.visit(href) - } - }) + cy.contains('Flow Collector') + .should('have.attr', 'href') + .invoke('attr', 'href') + .then(href => cy.visit(href))🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/cypress/views/netobserv.ts` around lines 122 - 135, In visitFlowcollector replace the silent guards that check `if (href)` with explicit assertions so the test fails fast when links are missing: for the operator row (`selector` built from Operator.name()) and the 'Flow Collector' cy.contains(...) call, assert the element has an 'href' (or that the element exists) before calling cy.visit with that href; remove the conditional no-op logic and use a cy.should/assert to fail the test when the link is absent.
🧹 Nitpick comments (2)
web/src/components/tabs/netflow-overview/netflow-overview-panel.tsx (1)
63-63: Make thedata-testselector resilient to missingid.
idis optional, so this can rendernetflow-overview-focus-undefinedand create duplicate selectors across panels. Either requireidwhenfocusOnis used, or add a guaranteed-unique fallback.Suggested adjustment
export interface NetflowOverviewPanelProps { doubleWidth: boolean; bodyClassName: string; title: string; titleTooltip?: string; kebab?: JSX.Element; onClick?: () => void; - focusOn?: (id?: string) => void; + focusOn?: (id: string) => void; isSelected?: boolean; isFocus?: boolean; - id?: string; + id: string; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/tabs/netflow-overview/netflow-overview-panel.tsx` at line 63, The data-test attribute on NetflowOverviewPanel currently uses the optional prop id and can render "netflow-overview-focus-undefined", causing duplicate selectors; update the JSX that sets data-test (the attribute currently written as data-test={`netflow-overview-focus-${id}`}) to use a guaranteed unique fallback when id is missing (for example id ?? a stable fallback such as React.useId(), a passed panelIndex prop, or derived string from focusOn) so the selector never contains "undefined" and remains unique across panels.web/cypress/integration-tests/quickFilters.cy.ts (1)
50-63: Drop the remaining container-id dependency.The checkbox interaction is better than the old class selector, but
#quick-filters-dropdownandparent()still tie the test to the current DOM structure. Use the label itself as the anchor for both toggle actions.Proposed selector cleanup
- cy.get('#quick-filters-dropdown').contains("Test NS") - cy.contains("Test NS").parent().find('input[type="checkbox"]').should('exist').click() + cy.contains('label', 'Test NS').find('input[type="checkbox"]').should('exist').click() ... - cy.contains("Test NS").parent().find('input[type="checkbox"]').should('exist').click() + cy.contains('label', 'Test NS').find('input[type="checkbox"]').should('exist').click()As per coding guidelines: Verify E2E test stability, proper waits, and selector resilience.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/cypress/integration-tests/quickFilters.cy.ts` around lines 50 - 63, The test is brittle because it relies on '#quick-filters-dropdown' and parent() DOM traversal; instead anchor interactions to the visible label text ("Test NS") and the "Quick filters" trigger so the checkbox toggle doesn't depend on container structure. Replace uses of '#quick-filters-dropdown' and .parent() with a label-based lookup anchored on the "Test NS" text (e.g., locate the label containing "Test NS" and operate on the input within it) for both checking and unchecking, ensure the "Quick filters" button is visible before clicking, and keep the final assertion that the filters element is removed (currently '#filters') but validate visibility/absence with a stable assertion.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/cypress/fixtures/gateway-api.yaml`:
- Around line 118-121: The curl loop in the traffic generator (the while true
... curl -s ... sleep 5 loop) never sets the Host header so requests won't match
the Gateway/HTTPRoute; update the curl invocation inside that loop to include
the Host header for gwapi.example.com (use curl's -H "Host: gwapi.example.com")
so the request hostname matches the Gateway and routes to echo-service.
In `@web/cypress/integration-tests/netflow_export.cy.ts`:
- Around line 42-53: After clicking the export button
(cy.byTestID('export-button') inside the export-modal) replace the raw
cy.exec("ls cypress/downloads") + immediate mv with a polling/assertion that
waits for the CSV to appear (e.g., loop or use Cypress retryable commands such
as cy.readFile or a wait-until helper) and assert there is exactly one matching
download before attempting to rename it; specifically update the block that
calls cy.exec("ls cypress/downloads", { timeout: 10000 }).then(...) and the
subsequent cy.exec(`mv ...`) so it first waits for the expected file path to
exist (and is unique) and only then performs the rename and readFile, and
finally clean up the file with the existing rm call.
In `@web/cypress/integration-tests/topology_edges_labels.cy.ts`:
- Around line 23-25: Move the cy.intercept call so it runs before the scope
selection occurs: place the intercept for
topologyPage.getTopologyResourceScopeGroupURL('owners') ahead of the call to
topologyPage.selectScopeGroup("resource", "owners") (which executes in
beforeEach), ensuring cy.intercept(...) is registered before the owners request
is sent so the fixture (flowmetrics/Owners.json) is used instead of live data.
In `@web/cypress/support/commands.ts`:
- Around line 332-346: The cliLogin command silently allows auth failures and
exposes credentials: validate required envs (KUBECONFIG_PATH, LOGIN_USERNAME,
LOGIN_PASSWORD) at the start of Cypress.Commands.add("cliLogin"); stop using
failOnNonZeroExit: false on the oc login cy.exec call so failures surface (or
explicitly check loginresult.code and throw/cy.log + throw on non-zero); avoid
embedding loginPassword directly into the command string (e.g., use a secure
input mechanism or pass the password via stdin/environment to oc, and do not log
raw stdout/stderr that may contain secrets), and replace the current
cy.log(loginresult.stderr|stdout) usage with masked/conditional logging or an
error throw when login fails; reference these symbols: cliLogin, kubeconfig,
loginUsername, loginPassword, cy.exec, loginresult.
In `@web/cypress/views/list-page.ts`:
- Around line 61-65: The selector is flaky because it uses index-based selection
and a global contains: instead of
cy.get('[data-ouia-component-id="DataViewFilters"]').within(() =>
cy.get('button').first().click()) and cy.contains('li', 'Name').click(), scope
the click to the specific filter dropdown element (e.g., target the button that
opens the Name filter by a more specific selector or add a dedicated data hook)
and then search for the "Name" list item only inside the opened dropdown
container (or the menu element with aria attributes) before clicking; update the
helper that contains these steps in list-page.ts to remove .first() and the
global cy.contains and replace them with scoped selectors or a dedicated
data-ouia/data-test hook for the dropdown and its "Name" item.
In `@web/cypress/views/netflow-page.ts`:
- Around line 87-89: The CSS selector used in the Cypress.$ check is malformed
(missing the closing quote/bracket for the transform attribute) in
web/cypress/views/netflow-page.ts; update the selector inside the Cypress.$(...)
call to include the missing quote and closing bracket so it reads something like
[data-surface=true][transform="translate(0, 0) scale(1)"] and keep the rest of
the conditional logic (the cy.get(...).click()) unchanged.
In `@web/cypress/views/netobserv-logo.ts`:
- Around line 11-20: The current test captures a static snapshot by filtering
$nodes inside the .then() callback (nodesWithSvg), which prevents Cypress'
automatic retry from waiting for child <svg> elements; replace that pattern with
a fully retryable selector chain: call cy.get with the same parent selector
(`g[data-id*="o=${resourceType}.${resourceName}"]`) and then use .find('svg')
(or a combined selector `g[data-id*="o=${resourceType}.${resourceName}"] svg`)
and assert on the returned collection with .should('have.length.greaterThan', 0)
and .first().should('be.visible') so the lookup for SVGs is retried instead of
filtered from a static snapshot (update usages of nodesWithSvg and the .then()
block accordingly).
In `@web/cypress/views/netobserv.ts`:
- Around line 260-262: The cy.exec call is interpolating the kubeconfig path
unquoted (kubeconfig variable) which is unsafe for paths with spaces and risks
shell injection; update the invocation around cy.exec(`oc get sc --kubeconfig
${kubeconfig}`) to quote the path by using JSON.stringify(kubeconfig) (or an
equivalent shell-safe quoting) when building the command string so the
kubeconfig value is safely passed to the shell.
In `@web/cypress/views/network-health.ts`:
- Around line 17-25: The close click on the health card should also use a forced
click to avoid intermittent failures when the side panel overlaps the card;
update the second click on the button returned by
cy.get(`[data-test^="health-card-${name}"]`).eq(0).find('button') to include {
force: true } so the code that checks networkHealthSelectors.sidePanel no longer
flakes—keep the initial forced click and add the same forced option to the
closing click, preserving the surrounding visibility/assertion checks for mode
and alertText.
---
Outside diff comments:
In `@web/cypress/integration-tests/netflow_zone_multiCluster.cy.ts`:
- Around line 23-25: The intercept for the network call must be registered
before the scope change so the fixture can stub the request; move the
cy.intercept(...) that stubs the topology request into the setup that runs
before topologyPage.selectScopeGroup("resource", "owners") (e.g. the beforeEach
or immediately before calling selectScopeGroup), ensuring the stub is active
before the request fires; keep references to cy.intercept,
topologyPage.selectScopeGroup("resource","owners"), and
cy.openColumnsModal()/colSelectors.columnsModal so you can locate and update the
test code.
In `@web/cypress/integration-tests/table_queryopts.cy.ts`:
- Around line 46-69: The test is using parseFloat on the summary metric texts
(in the it block that checks query summary panel) which fails for
compact/localized formats like "1.5k" or "1,234"; add a small parsing helper
(e.g., parseCompactCount) that normalizes strings by removing thousands
separators, handling suffixes like k/K, m/M, g/G (multiplying accordingly) and
trimming plus signs, then use that helper in place of parseFloat when reading
querySumSelectors.flowsCount, querySumSelectors.bytesCount and
querySumSelectors.packetsCount so the assertions compare the true numeric
values.
In `@web/cypress/views/netobserv.ts`:
- Around line 122-135: In visitFlowcollector replace the silent guards that
check `if (href)` with explicit assertions so the test fails fast when links are
missing: for the operator row (`selector` built from Operator.name()) and the
'Flow Collector' cy.contains(...) call, assert the element has an 'href' (or
that the element exists) before calling cy.visit with that href; remove the
conditional no-op logic and use a cy.should/assert to fail the test when the
link is absent.
In `@web/src/components/metrics/histogram.tsx`:
- Around line 268-275: The icon-only Buttons in histogram.tsx lack accessible
names; add explicit aria-label attributes to each icon-only control (for example
the Buttons with data-test="histogram-double-left", "histogram-left",
"histogram-right", "histogram-double-right" and any other arrow/zoom Buttons)
that describe the action (e.g., "Move range to start", "Move range left", "Move
range right", "Move range to end"); keep the existing tooltip and
className/refs/onClick (e.g., moveRange, arrowRef, loading) unchanged and ensure
the aria-label is a clear, concise verb phrase so screen readers can announce
the control.
---
Nitpick comments:
In `@web/cypress/integration-tests/quickFilters.cy.ts`:
- Around line 50-63: The test is brittle because it relies on
'#quick-filters-dropdown' and parent() DOM traversal; instead anchor
interactions to the visible label text ("Test NS") and the "Quick filters"
trigger so the checkbox toggle doesn't depend on container structure. Replace
uses of '#quick-filters-dropdown' and .parent() with a label-based lookup
anchored on the "Test NS" text (e.g., locate the label containing "Test NS" and
operate on the input within it) for both checking and unchecking, ensure the
"Quick filters" button is visible before clicking, and keep the final assertion
that the filters element is removed (currently '#filters') but validate
visibility/absence with a stable assertion.
In `@web/src/components/tabs/netflow-overview/netflow-overview-panel.tsx`:
- Line 63: The data-test attribute on NetflowOverviewPanel currently uses the
optional prop id and can render "netflow-overview-focus-undefined", causing
duplicate selectors; update the JSX that sets data-test (the attribute currently
written as data-test={`netflow-overview-focus-${id}`}) to use a guaranteed
unique fallback when id is missing (for example id ?? a stable fallback such as
React.useId(), a passed panelIndex prop, or derived string from focusOn) so the
selector never contains "undefined" and remains unique across panels.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dd609d2c-497c-47f9-9362-be79cd658ede
📒 Files selected for processing (56)
web/cypress/fixtures/gateway-api-template.yamlweb/cypress/fixtures/gateway-api.yamlweb/cypress/integration-tests/client_performance.cy.tsweb/cypress/integration-tests/dns_dashboards.cy.tsweb/cypress/integration-tests/dns_tracking.cy.tsweb/cypress/integration-tests/flowRTT.cy.tsweb/cypress/integration-tests/flowRTT_dashboards.cy.tsweb/cypress/integration-tests/flow_dashboards_bytes.cy.tsweb/cypress/integration-tests/flow_dashboards_packets.cy.tsweb/cypress/integration-tests/gateway_topology_logo.cy.tsweb/cypress/integration-tests/health_dashboards.cy.tsweb/cypress/integration-tests/ingress_dashboard.cy.tsweb/cypress/integration-tests/netflow_conversations.cy.tsweb/cypress/integration-tests/netflow_developer_view.cy.tsweb/cypress/integration-tests/netflow_export.cy.tsweb/cypress/integration-tests/netflow_external_subnet.cy.tsweb/cypress/integration-tests/netflow_table.cy.tsweb/cypress/integration-tests/netflow_zone_multiCluster.cy.tsweb/cypress/integration-tests/netobserv_udn.cy.tsweb/cypress/integration-tests/network_health.cy.tsweb/cypress/integration-tests/overview_page.cy.tsweb/cypress/integration-tests/packet_drop.cy.tsweb/cypress/integration-tests/packet_drop_dashboards.cy.tsweb/cypress/integration-tests/prom_datasource_only.cy.tsweb/cypress/integration-tests/quickFilters.cy.tsweb/cypress/integration-tests/static_plugin.cy.tsweb/cypress/integration-tests/table_queryopts.cy.tsweb/cypress/integration-tests/topology_edges_labels.cy.tsweb/cypress/integration-tests/topology_groups.cy.tsweb/cypress/integration-tests/topology_view.cy.tsweb/cypress/integration-tests/workloads.cy.tsweb/cypress/support/commands.tsweb/cypress/views/dashboards-page.tsweb/cypress/views/list-page.tsweb/cypress/views/netflow-page.tsweb/cypress/views/netobserv-logo.tsweb/cypress/views/netobserv.tsweb/cypress/views/network-health.tsweb/cypress/views/operator-hub-page.tsweb/cypress/views/pages.tsweb/cypress/views/yaml-editor.tsweb/src/components/drawer/record/record-panel.tsxweb/src/components/forms/consumption.tsxweb/src/components/forms/dynamic-form/dynamic-form.tsxweb/src/components/forms/dynamic-form/fields.tsxweb/src/components/forms/dynamic-form/templates.tsxweb/src/components/forms/dynamic-form/widgets.tsxweb/src/components/forms/flowCollector-status.tsxweb/src/components/forms/flowCollector-wizard.tsxweb/src/components/health/health-card.tsxweb/src/components/health/health-drawer-container.tsxweb/src/components/health/rule-details.tsxweb/src/components/messages/error.tsxweb/src/components/metrics/histogram.tsxweb/src/components/query-summary/summary-panel-content.tsxweb/src/components/tabs/netflow-overview/netflow-overview-panel.tsx
💤 Files with no reviewable changes (1)
- web/cypress/fixtures/gateway-api-template.yaml
Member
Author
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
|
New image: quay.io/netobserv/network-observability-console-plugin:a3a0b2c
It will expire in two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=a3a0b2c make set-plugin-image |
6 tasks
github-actions
Bot
removed
the
ok-to-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-pf5 #1459 +/- ##
=========================================
Coverage 52.53% 52.53%
=========================================
Files 232 232
Lines 12355 12355
Branches 1551 1551
=========================================
Hits 6491 6491
Misses 5269 5269
Partials 595 595
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
github-actions
Bot
removed
the
ok-to-test
Member
Author
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
|
New image: quay.io/netobserv/network-observability-console-plugin:6f2ca64
It will expire in two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=6f2ca64 make set-plugin-image |
github-actions
Bot
removed
the
ok-to-test
Amoghrd
force-pushed
the
update-pf5-tests
branch
3 times, most recently
from
a5c0328 to
1f0ea90
Compare
Amoghrd
added a commit
to Amoghrd/netobserv-web-console
that referenced
this pull request
Apr 29, 2026
- Remove duplicate cliLogin command registration in commands.ts - Add .clear() before .type() in network_health.cy.ts to prevent flakes - Fix topology selector in client_performance.cy.ts - Update memory and load time thresholds to match PR netobserv#1459 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Amoghrd
force-pushed
the
update-pf5-tests
branch
3 times, most recently
from
6d5ee02 to
afbdca3
Compare
Member
Author
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
|
New image: quay.io/netobserv/network-observability-console-plugin:aee6db2
It will expire in two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=aee6db2 make set-plugin-image |
github-actions
Bot
removed
the
ok-to-test
Member
|
@Amoghrd - I can't see the diff for commit b0d4f1d because of force push, but when I was working on migration I had code generated by claude so that we can manage selectors compatibility and test selection dynamically for different ocp versions . I didn't commit this since we adopted different branch strategy but by looking at the commit message of b0d4f1d, I wonder, if it would be something that will help to what you're trying to do in that commit? |
Member
Author
|
I reverted it. |
Member
Author
|
4.20 jenkins run: noo-frontend-tests#61 -> Quick filters is flaky due to usage of client server template. Converting that to basic YAML and also moving the deployment post flowcollector install. It passed locally. Will verify it jenkins on other OCP versions. |
Member
Author
|
/hold |
jpinsonneau
previously approved these changes
May 11, 2026
Member
|
@Amoghrd did you mean to put hold on this PR? I don't think this repo recognizes that label :) |
Member
Author
|
Yeah, I wanted to hold it. I am looking into a better approach for skipping the tests(gateway, UDN) based on OCP versions. |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
Jenkins runs have been pasted in PR description, the failing tests were due to incorrect logic in test skip(UDN, gateway). Fixed the issue and UDN passing and gateway_topology skipped on 4.18 |
Member
Author
|
Imaginary /unhold :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependencies
PF5 cluster(e.g. OCP 4.18)
Checklist
Test Results:
Failing tests passed on rerun
Jenkins runs:
Summary by CodeRabbit
Tests
Chores