NETOBSERV-2608: TLS, metrics and charts [pf5]

[jotak]

Description

• Add 4 new overview panels related to TLS:
  • TLS global usage (traffic with/without TLS)
  • breakdown by version
  • breakdown by group
  • breakdown by cipher suite
• Add new column filter "tls" in manage columns panel
• Fix issues in logQL when querying on arrays: handle looking for field presence/absence
• Refactoring: introduce StructuredFlowQuery, an intermediate data structure used before the flow query is entirely serialized for HTTP. It allows to keep and manipulate structured filters for complex queries.

Dependencies

• Operator: NETOBSERV-2608: TLS metrics netobserv-operator#2707

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-2608 which is a valid jira issue.

Details

In response to this:

Description

• Add 4 new overview panels related to TLS:
• TLS global usage (traffic with/without TLS)
• breakdown by version
• breakdown by group
• breakdown by cipher suite
• Add new column filter "tls" in manage columns panel
• Fix issues in logQL when querying on arrays: handle looking for field presence/absence
• Refactoring: introduce StructuredFlowQuery, an intermediate data structure used before the flow query is entirely serialized for HTTP. It allows to keep and manipulate structured filters for complex queries.

Dependencies

• Operator: NETOBSERV-2608: TLS metrics netobserv-operator#2707

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

(I haven't tested yet the no-loki scenario, need to do that)

edit: test done

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 499eecfe-257a-4008-b315-86d92df94e67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 47.20497% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.30%. Comparing base (acc8a6f) to head (3e25843).

Files with missing lines	Patch %	Lines
...ponents/tabs/netflow-overview/netflow-overview.tsx	30.33%	58 Missing and 4 partials ⚠️
web/src/utils/back-and-forth.ts	71.42%	6 Missing and 2 partials ⚠️
pkg/model/filters/logql.go	0.00%	6 Missing ⚠️
web/src/utils/metrics.ts	0.00%	3 Missing ⚠️
pkg/loki/flow_query.go	85.71%	2 Missing ⚠️
web/src/components/metrics/metrics-donut.tsx	0.00%	1 Missing and 1 partial ⚠️
web/src/utils/overview-panels.ts	66.66%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           main-pf5    #1478      +/-   ##
============================================
- Coverage     52.53%   52.30%   -0.24%     
============================================
  Files           232      232              
  Lines         12355    12444      +89     
  Branches       1551     1559       +8     
============================================
+ Hits           6491     6509      +18     
- Misses         5269     5335      +66     
- Partials        595      600       +5     

Flag	Coverage Δ
uitests	56.39% <45.39%> (-0.35%)	⬇️
unittests	40.94% <60.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
web/src/api/loki.ts	84.61% <ø> (-1.60%)	⬇️
...b/src/components/drawer/netflow-traffic-drawer.tsx	47.70% <ø> (ø)
web/src/components/modals/columns-modal.tsx	56.00% <100.00%> (ø)
web/src/components/modals/export-modal.tsx	68.57% <ø> (ø)
web/src/model/config.ts	100.00% <ø> (ø)
web/src/model/filters.ts	81.69% <ø> (ø)
web/src/model/flow-query.ts	91.66% <100.00%> (+1.66%)	⬆️
web/src/model/netflow-context.ts	70.00% <ø> (ø)
web/src/utils/netflow-capabilities-hook.ts	70.52% <100.00%> (-0.91%)	⬇️
pkg/loki/flow_query.go	67.76% <85.71%> (+0.65%)	⬆️
... and 6 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Amoghrd]

/ok-to-test

[github-actions]

New image:

quay.io/netobserv/network-observability-console-plugin:1654466

It will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=1654466 make set-plugin-image

[openshift-ci]

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/qe-e2e-console-tests	cb0da63	link	false	/test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.