Open
Conversation
Member
|
thanks |
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
dg
force-pushed
the
master
branch
2 times, most recently
from
be881cd to
db11685
Compare
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
dg
force-pushed
the
master
branch
2 times, most recently
from
bee1f04 to
7ffe057
Compare
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
dg
force-pushed
the
master
branch
2 times, most recently
from
9699205 to
c2ab3e5
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
17c00a9 to
e58375f
Compare
Member
|
Hi Jakub, thanks for the patch! I'm a bit hesitant to merge a workaround for a bug I can't reproduce or fully understand — the check might just mask a deeper issue rather than fix the root cause. Could you share a minimal repro, or at least a stack trace showing which call it is and what kind of object is involved? That would help me figure out what's actually going wrong. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't pinpoint the exact configuration (my PHP version is 8.4.16) but under some conditions, an exception thrown inside an exception handler kills PHP-FPM in the most brutal way with no errors logged or printed anywhere. Debugging this was a nightmare. A simple check for function existence fixes the problem.