Skip to content

Apply v1.0.18#175

Merged
nettrash merged 4 commits intomasterfrom
v1.0.18
Apr 25, 2026
Merged

Apply v1.0.18#175
nettrash merged 4 commits intomasterfrom
v1.0.18

Conversation

@nettrash
Copy link
Copy Markdown
Owner

No description provided.

iBarBuba and others added 3 commits April 25, 2026 18:18
* Fix grants for former owners after owner change

* Address ACL review comments

* Simplify ACL owner filtering API

---------

Co-authored-by: iBarBuba <350579+iBarBuba@users.noreply.github.com>
@nettrash nettrash added this to the v1.0.18 milestone Apr 25, 2026
@nettrash nettrash self-assigned this Apr 25, 2026
@nettrash nettrash added the enhancement New feature or request label Apr 25, 2026
Copilot AI review requested due to automatic review settings April 25, 2026 20:21
@nettrash nettrash changed the title V1.0.18 Apply v1.0.18 Apr 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release prep for v1.0.18, focused on fixing grant/ACL diff correctness (esp. owner-change + foreign tables), improving dump efficiency, and strengthening regression coverage/CI.

Changes:

  • Fix grant diffing around ALTER ... OWNER TO by introducing asymmetric from_owners / to_owners filtering, and improve ACL parsing for quoted role names.
  • Fix foreign table privilege handling (privilege set + GRANT ... ON TABLE emission) and add targeted regression tests.
  • Add CI round-trip/idempotency integration tests across multiple PostgreSQL versions; bump crate version + update changelog/test schemas.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
data/test/schema_b.sql Adds regression fixtures for former-owner explicit grants and foreign table grants.
data/test/README.md Documents the new regression scenarios in the test schema.
app/src/dump/core.rs Fetches server_version_num once and threads it into dump branches; simplifies schema fetch error handling.
app/src/dump/acl.rs Robust aclitem parsing (quoted grantees/grantors), FOREIGN TABLE privilege set fix, asymmetric owner filtering, and new unit tests.
app/src/config/core.rs Warns early when FROM/TO host is empty to avoid confusing downstream connection failures.
app/src/comparer/core_tests.rs Adds comparer-level regression tests for foreign table grants + owner-change idempotency + dependency scanning.
app/src/comparer/core.rs Implements asymmetric owner filtering at call sites; fixes foreign table GRANT syntax; adds reusable drop-emission helper; improves dependency needle matching.
app/Cargo.toml Bumps app version to 1.0.18.
app/Cargo.lock Updates lockfile for the version bump.
CHANGELOG Adds detailed v1.0.18 release notes.
.gitignore Adjusts ignores and adds test.sh.
.github/workflows/rust.yml Adds matrix integration job that validates idempotent round-trips across PG 14–18.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/comparer/core.rs Outdated
@nettrash nettrash merged commit a1d0cda into master Apr 25, 2026
4 checks passed
@nettrash nettrash deleted the v1.0.18 branch April 25, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants