Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Release prep for v1.0.18, focused on fixing grant/ACL diff correctness (esp. owner-change + foreign tables), improving dump efficiency, and strengthening regression coverage/CI.
Changes:
- Fix grant diffing around
ALTER ... OWNER TOby introducing asymmetricfrom_owners/to_ownersfiltering, and improve ACL parsing for quoted role names. - Fix foreign table privilege handling (privilege set +
GRANT ... ON TABLEemission) and add targeted regression tests. - Add CI round-trip/idempotency integration tests across multiple PostgreSQL versions; bump crate version + update changelog/test schemas.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| data/test/schema_b.sql | Adds regression fixtures for former-owner explicit grants and foreign table grants. |
| data/test/README.md | Documents the new regression scenarios in the test schema. |
| app/src/dump/core.rs | Fetches server_version_num once and threads it into dump branches; simplifies schema fetch error handling. |
| app/src/dump/acl.rs | Robust aclitem parsing (quoted grantees/grantors), FOREIGN TABLE privilege set fix, asymmetric owner filtering, and new unit tests. |
| app/src/config/core.rs | Warns early when FROM/TO host is empty to avoid confusing downstream connection failures. |
| app/src/comparer/core_tests.rs | Adds comparer-level regression tests for foreign table grants + owner-change idempotency + dependency scanning. |
| app/src/comparer/core.rs | Implements asymmetric owner filtering at call sites; fixes foreign table GRANT syntax; adds reusable drop-emission helper; improves dependency needle matching. |
| app/Cargo.toml | Bumps app version to 1.0.18. |
| app/Cargo.lock | Updates lockfile for the version bump. |
| CHANGELOG | Adds detailed v1.0.18 release notes. |
| .gitignore | Adjusts ignores and adds test.sh. |
| .github/workflows/rust.yml | Adds matrix integration job that validates idempotent round-trips across PG 14–18. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.