Skip to content

Fixed Junos reboots not being detected when waiting for the device to reload#394

Open
Defiantearth wants to merge 5 commits into
developfrom
u/defiantearth/NAPPS-1176/fix-junos-reboot
Open

Fixed Junos reboots not being detected when waiting for the device to reload#394
Defiantearth wants to merge 5 commits into
developfrom
u/defiantearth/NAPPS-1176/fix-junos-reboot

Conversation

@Defiantearth
Copy link
Copy Markdown

@Defiantearth Defiantearth commented May 27, 2026

NAPPS-1176

What's Changed

  • Updated the Juniper uptime property to refresh the device facts when _uptime is None, so it returns the live uptime instead of a stale cached value.
  • Updated _wait_for_device_reboot to capture the pre-reboot uptime, close the connection, then poll every 10 seconds and treat the device as rebooted once the new uptime is lower than the original.
  • Increased timeout from 3600 to 7200 seconds

Screenshot of OS Upgrades failing after Install OS because it did not wait for reboot correctly(Before).

localhost_8080_extras_job-results_4e712315-dcf2-4586-a4a2-a9d41248ca0f_

Screenshot of OS Upgrades working Successfully(After).

localhost_8080_extras_job-results_f4b05895-c7d3-4173-bbd9-6c731d936795_

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@Defiantearth Defiantearth marked this pull request as ready for review May 27, 2026 20:24
Copy link
Copy Markdown

@Pkawa-ntc Pkawa-ntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my nitpicks, other than them, LGTM.

Comment thread pyntc/devices/jnpr_device.py
Comment thread changes/394.fixed
Comment thread pyntc/devices/jnpr_device.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants