FIX: Respect Joblib context in config sync (Issue #76)#154
Closed
ANJAN672 wants to merge 3 commits into
Closed
Conversation
Member
Schefflera-Arboricola
left a comment
There was a problem hiding this comment.
Thanks for the PR @ANJAN672 !
When using joblib.parallel_config(n_jobs=X), nx-parallel was ignoring the value and always using nx.config.backends.parallel.n_jobs
you can change that by setting active=False in nx.config , read - https://github.com/networkx/nx-parallel/blob/main/Config.md
Also read - #76 (comment) -- And please consider closing this PR if you agree with it. Thx!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76 (partial)
Problem
When using
joblib.parallel_config(n_jobs=X), nx-parallel was ignoring the value and always usingnx.config.backends.parallel.n_jobs.Solution
Known Limitation
When NX context is nested inside Joblib context, Joblib still wins. Full sync requires upstream changes to both libraries.
Tests
All 89 existing tests pass.