Fix broken image path in SharePoint Online KB article

[hilram7]

Updates the image reference in
sharepoint-online-activity-scan-warning-unknown-item-type.md to correctly point to the image location after the file was moved from
docs/kb/activitymonitor to docs/kb/accessanalyzer in PR #81.

Changes the relative path from ../0-images/ to ../../activitymonitor/0-images/ to
maintain compatibility with version-specific docs that still reference this image.

[github-actions]

Pull Request Review

Summary

This PR fixes a broken image reference in the SharePoint Online KB article after the file was moved from docs/kb/activitymonitor to docs/kb/accessanalyzer in PR #81. The fix involves copying the image to the accessanalyzer folder and updating the markdown to use a local relative path.

Code Quality: ✅ Excellent

Strengths:

• Correct approach: Copying the image to the accessanalyzer folder ensures proper versioning when the copy-kb-to-versions.js script runs
• Clean path reference: Using ../0-images/ instead of ../../activitymonitor/0-images/ maintains proper documentation structure
• Whitespace cleanup: Removed trailing spaces on line 53 (good housekeeping)

Analysis

File Changes:

1. Binary image copied: docs/kb/accessanalyzer/0-images/ka0Qk000000CnwD_0EMQk00000BF8bi.png (39,047 bytes)
2. Markdown updated: Changed image path from ../0-images/ to local reference

Version Script Compatibility:

The copy-kb-to-versions.js script (lines 37-42) is configured to copy KB articles from docs/kb/accessanalyzer to versioned folders:

• Source: docs/kb/accessanalyzer
• Destinations: docs/accessanalyzer/11.6/kb and docs/accessanalyzer/12.0/kb

This PR ensures the image will be included when the script copies content to version-specific folders.

Potential Issues: ⚠️ Minor

1. Image duplication: The image now exists in two locations:

   • docs/kb/activitymonitor/0-images/ka0Qk000000CnwD_0EMQk00000BF8bi.png
   • docs/kb/accessanalyzer/0-images/ka0Qk000000CnwD_0EMQk00000BF8bi.png

   Recommendation: Consider whether the original image in activitymonitor should be removed if it's no longer referenced elsewhere. You can verify with:

   grep -r "ka0Qk000000CnwD_0EMQk00000BF8bi.png" docs/kb/activitymonitor/

2. Frontmatter metadata: The article's frontmatter (line 18) still lists activitymonitor in the products array:

   products:
     - activitymonitor
     - access-analyzer

   This appears intentional since the article relates to both products, but worth confirming this is the desired tagging.

Performance: ✅ No Concerns

• Binary image file is reasonably sized (39KB)
• No performance impact from path changes

Security: ✅ No Concerns

• No security vulnerabilities identified
• File permissions are standard
• No executable code changes

Test Coverage: ℹ️ Verification Recommended

Manual testing checklist:

• Verify image displays correctly in the KB article at docs/kb/accessanalyzer/sharepoint-online-integration/sharepoint-online-activity-scan-warning-unknown-item-type.md
• Run node scripts/copy-kb-to-versions.js to ensure images copy correctly to versioned folders
• Check that versioned docs (11.6 and 12.0) display the image properly after running the copy script
• Verify no broken image links in the generated site

Best Practices: ✅ Followed

The solution correctly implements the documentation structure pattern:

• KB articles in docs/kb/{product}/ contain source content
• Images are co-located with their product's KB articles
• Relative paths ensure portability when content is copied to versioned folders
• The copy script handles the link rewriting automatically

Recommendation: ✅ Approve with Minor Cleanup

This PR correctly fixes the broken image path. Consider the optional cleanup of removing the duplicate image from activitymonitor if it's no longer needed. Otherwise, this is ready to merge.

---

Reviewed by Claude Code