Draft
Conversation
…ted authentication logic.
…es configurations. - Integrated deployment and service definitions for platformadmin, platformconfig, and platformnotifications components. - Updated `cluster.sh` to apply the new configuration files during cluster setup.
…, and migrations. - Added reusable Docker-based stubs for testing platformadmin (nginx), Kubernetes, and database migrations. - Updated integration tests to utilize new fixtures (`docker_smart_stubs`, `kube_api_stub`, and `run_platformadmin_migrations`). - Replaced platformauthapi references with platformadmin in tests and configurations. - Enhanced Docker network handling with isolated test environment setup.
…r improved test coverage.
- Added support for new API routes (`/api/v1/notifications`, `/api/v1/users/{user}/token`, `/api/v1/clusters`) in stubs.
- Improved `create_local_app_server` to dynamically assign ports and expose the address.
- Simplified `regular_user_factory` fixture and integrated cluster creation while handling exceptions.
- Adjusted `create_auth_config` and related logic to align with updated `neuro-admin-client` behavior.
…e exception handling in auth integration tests.
…on handling logic - Replaced custom authorization logic with `get_untrusted_user_name` from `neuro-admin-client`. - Streamlined permission filtering using `get_authorized_entities` API. - Updated dependency version and adjusted `pyproject.toml` and `poetry.lock` accordingly.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 20185324 | Triggered | JSON Web Token | 475eff1 | tests/k8s/platformadmin.yml | View secret |
| 20296912 | Triggered | Generic High Entropy Secret | 4fd065a | tests/integration/stubs.py | View secret |
| 17292849 | Triggered | JSON Web Token | 475eff1 | tests/k8s/platformadmin.yml | View secret |
| 17292850 | Triggered | JSON Web Token | 475eff1 | tests/k8s/platformnotifications.yml | View secret |
| 20185325 | Triggered | JSON Web Token | 475eff1 | tests/k8s/platformconfig.yml | View secret |
| 10550565 | Triggered | Generic Password | 475eff1 | tests/k8s/platformconfig.yml | View secret |
| 16706040 | Triggered | JSON Web Token | 475eff1 | tests/k8s/platformadmin.yml | View secret |
| 15010373 | Triggered | Generic High Entropy Secret | 475eff1 | tests/k8s/platformnotifications.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.