Skip to content

feat: add refresh_*_with_options for parsing with timeout#27

Open
rmehri01 wants to merge 1 commit into
neurocyte:masterfrom
rmehri01:parse_timeout
Open

feat: add refresh_*_with_options for parsing with timeout#27
rmehri01 wants to merge 1 commit into
neurocyte:masterfrom
rmehri01:parse_timeout

Conversation

@rmehri01

Copy link
Copy Markdown

Adds refresh_from_buffer_with_options and refresh_from_string_with_options which support a timeout.

Some small cleanups:

  • Remove syntax: *Self from refresh_from_buffer since it isn't being used.
  • Remove sentinel requirement from refresh_from_string since I don't think it is needed anywhere.
  • Implement refresh_from_string in terms of refresh_from_buffer since they are almost identical.

Note I haven't tested this with flow yet since it doesn't compile on 0.17-dev.

Closes #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support parsing with a timeout

1 participant