feat: add refresh_*_with_options for parsing with timeout#27
Open
rmehri01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
refresh_from_buffer_with_optionsandrefresh_from_string_with_optionswhich support a timeout.Some small cleanups:
syntax: *Selffromrefresh_from_buffersince it isn't being used.refresh_from_stringsince I don't think it is needed anywhere.refresh_from_stringin terms ofrefresh_from_buffersince they are almost identical.Note I haven't tested this with flow yet since it doesn't compile on 0.17-dev.
Closes #22