Fix signed/unsigned mismatch in DpcProcessor::ComputeResultImages#23
Draft
Copilot wants to merge 3 commits intoissue19_conanfrom
Draft
Fix signed/unsigned mismatch in DpcProcessor::ComputeResultImages#23Copilot wants to merge 3 commits intoissue19_conanfrom
Copilot wants to merge 3 commits intoissue19_conanfrom
Conversation
Merged
Co-authored-by: anderskaestner <11174364+anderskaestner@users.noreply.github.com>
Co-authored-by: anderskaestner <11174364+anderskaestner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #21 on Issue19 conan adjustments
Fix signed/unsigned mismatch in DpcProcessor::ComputeResultImages
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #21 regarding unnecessary type conversion in
nGIProcessor.cppthat created a signed/unsigned mismatch.Changes
Nfromptrdiff_tback tosize_tto matchopenbeamDC.Size()return typefor (ptrdiff_t i=0; i<static_cast<ptrdiff_t>(N); i++)Before:
After:
This preserves the natural unsigned type while maintaining OpenMP compatibility where
ptrdiff_tis required for the loop variable.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.