Suppress the annoying np.datetime64 errors#670
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #670 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 77 77
Lines 7055 7059 +4
=======================================
+ Hits 6792 6796 +4
Misses 263 263
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
I tested this today using the original replicator and this seems to have solved the problem. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
afab9c8 to
ac21b76
Compare
walshmm
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Recently,
numpyfully deprecated the use of timezone offsets innp,datetime64constructor from strings. This was throwing useless errors that confused users and made it seem that every SNAPRed reduction was failing.These were handled by suppressing the errors inside of the central
Time.pymodule.Explanation of work
This context manager successfully removes the error:
To test
Dev testing
Open, and try running a complete calibration run.
CIS testing
Please run an entire reduction run for a suitable file.
Link to EWM item
EWM#14998
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.