Skip to content

#441, #438, #443, #418#442

Merged
lsongsuse merged 5 commits intoneuvector:mainfrom
xingzhang-suse:main
Feb 24, 2026
Merged

#441, #438, #443, #418#442
lsongsuse merged 5 commits intoneuvector:mainfrom
xingzhang-suse:main

Conversation

@xingzhang-suse
Copy link
Contributor

#438 Over all styling review issues on whole product
#441 Reported issues after UX/UI review for Workload scan features - Except Workload configurations and reports

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 90.27778% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.71%. Comparing base (c2c67f9) to head (51d4cbc).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   84.79%   85.71%   +0.92%     
==========================================
  Files          97       97              
  Lines       14056    14103      +47     
  Branches     1019     1064      +45     
==========================================
+ Hits        11919    12089     +170     
+ Misses       2110     1985     -125     
- Partials       27       29       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xingzhang-suse xingzhang-suse changed the title #441, #438 #441, #438, #443, #418 Feb 24, 2026
/>
<span v-if="value.error">|
<span v-if="value.error">
<span style="color: #BFC1D1">|</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the styling theme-compliant, could you replace the inline style with a CSS class instead? For example:

<span class="separator">|</span>

.separator {
  color: var(--disabled-text);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed into class for ProgressCell.vue and PreviousScanCell.vue.
The color should match with design not the theme's color. It works for both light and dark theme.

@lsongsuse lsongsuse merged commit 2c4a399 into neuvector:main Feb 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants