[codex] Prevent stale xPoster image markers#1
Open
aa755 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created and submitted by codex
What changed
This makes Article imports fail-safe when X's async media upload flow races with xPoster's marker cleanup.
__XPOSTER_...marker survives cleanup.Why
A real published Article ended up with an image marker such as
__XPOSTER_f4m2b_IMAGE_1__visible above an uploaded image. The likely interleaving is that xPoster removed a marker, then X applied a later media-upload state update from an older editor snapshot that still contained that marker. The image upload succeeded, but the temporary marker came back.Validation
npm run checkpassed.git diff --checkpassed.npm testcurrently fails on upstreammainbefore reaching this change:shared.normalizeAiCoverSettings is not a functioninscripts/smoke-test.js.