This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Use fallthrough attribute instead of comment as the comment no longer works in Clang 10.#25
Open
BoboFraggins wants to merge 2 commits intonewrelic:mainfrom
Open
Use fallthrough attribute instead of comment as the comment no longer works in Clang 10.#25BoboFraggins wants to merge 2 commits intonewrelic:mainfrom
BoboFraggins wants to merge 2 commits intonewrelic:mainfrom
Conversation
… works in Clang 10.
|
|
…ns of clang and gcc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 10 stopped supporting fallthrough comments in favor of the statement attribute 'fallthrough'.
For reference:
https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html
And, where the code maintainer of Clang explains the issue:
https://bugs.llvm.org/show_bug.cgi?id=43465#c37
He suggests either updating to the new style or turning off the warning. I assume you would prefer to not turn off the warning, although I don't know what version of gcc is used.