Skip to content

Update prometheus relationships to use identifier fragments for lookup#2730

Merged
apoloa merged 3 commits intonewrelic:mainfrom
maxa101:k8s-prometheus-relationship
Apr 9, 2026
Merged

Update prometheus relationships to use identifier fragments for lookup#2730
apoloa merged 3 commits intonewrelic:mainfrom
maxa101:k8s-prometheus-relationship

Conversation

@maxa101
Copy link
Copy Markdown
Contributor

@maxa101 maxa101 commented Mar 26, 2026

Relevant information

Api Review Board (ARB)

Any pull request with changes to this repository has to be linked with an ARB ticket, which has to be approved before merging.

If you are an external contributor please contact New Relic Support.

If you don't know about the ARB process check this

ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-541144

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.
  • I've linked an ARB ticket & received approval from API Review Board in order to make these changes

Copy link
Copy Markdown
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* No valid, approved ARB ticket found in the PR description.

@entityBot entityBot requested a review from a team March 26, 2026 20:38
@entityBot entityBot dismissed their stale review March 31, 2026 15:22

Let's validate those changes.

Copy link
Copy Markdown
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@maxa101 maxa101 marked this pull request as ready for review March 31, 2026 15:22
@entityBot entityBot dismissed their stale review March 31, 2026 15:22

Let's validate those changes.

Copy link
Copy Markdown
Collaborator

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@maxa101 maxa101 requested a review from entityBot April 8, 2026 17:21
kondracek-nr
kondracek-nr previously approved these changes Apr 8, 2026
@entityBot entityBot requested a review from a team April 8, 2026 17:41
@entityBot entityBot dismissed kondracek-nr’s stale review April 9, 2026 09:08

Dismissing reviews

@entityBot entityBot requested review from a team and removed request for a team April 9, 2026 09:08
@apoloa apoloa merged commit 8783460 into newrelic:main Apr 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants