Skip to content

feat: enhance log subscription verification to include destination ARN #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sashwatdas123 merged 2 commits into from
Feb 3, 2026
Merged

feat: enhance log subscription verification to include destination ARN #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1beb457
feat: enhance log subscription verification to include destination AR…
Sashwatdas123 Feb 3, 2026
bbe0673
refactor: formatted using black
Sashwatdas123 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions newrelic_lambda_cli/subscriptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ def create_log_subscription(input, function_name):
"Found log subscription for '%s', verifying configuration" % function_name
)
newrelic_filter = newrelic_filters[0]
if newrelic_filter["filterPattern"] != input.filter_pattern:
if (
newrelic_filter["filterPattern"] != input.filter_pattern
or newrelic_filter["destinationArn"] != destination_arn
):
return _remove_subscription_filter(
input.session, function_name, newrelic_filter["filterName"]
) and _create_subscription_filter(
Expand Down Expand Up @@ -189,7 +192,10 @@ def create_otel_log_subscription(input, function_name):
"Found log subscription for '%s', verifying configuration" % function_name
)
newrelic_filter = newrelic_filters[0]
if newrelic_filter["filterPattern"] != input.filter_pattern:
if (
newrelic_filter["filterPattern"] != input.filter_pattern
or newrelic_filter["destinationArn"] != destination_arn
):
return _remove_subscription_filter(
input.session, function_name, newrelic_filter["filterName"]
) and _create_subscription_filter(
Expand Down