feat: Add source mapping to CPU (wall time) profiler - #4095
Merged
amychisholm03 merged 4 commits intoJul 9, 2026
Conversation
amychisholm03
force-pushed
the
NR-4083/source-mapping
branch
2 times, most recently
from
July 6, 2026 20:39
f3cf356 to
269100d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4095 +/- ##
==========================================
- Coverage 97.48% 97.40% -0.08%
==========================================
Files 517 517
Lines 62214 62270 +56
Branches 1 1
==========================================
+ Hits 60647 60654 +7
- Misses 1567 1616 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amychisholm03
marked this pull request as ready for review
July 6, 2026 20:58
amychisholm03
force-pushed
the
NR-4083/source-mapping
branch
from
July 7, 2026 15:20
269100d to
b81bc00
Compare
1 task
bizob2828
requested changes
Jul 8, 2026
bizob2828
left a comment
bizob2828
left a comment
Member
There was a problem hiding this comment.
I don't think we could land this in the current state based on my comments
amychisholm03
force-pushed
the
NR-4083/source-mapping
branch
4 times, most recently
from
July 8, 2026 20:37
4a59a16 to
4c35d38
Compare
bizob2828
requested changes
Jul 8, 2026
bizob2828
left a comment
bizob2828
left a comment
Member
There was a problem hiding this comment.
tried using newrelic/newrelic-node-examples#378 but i don't see any samples that have user code in it. it's all either the agent or core node code. either way take a look at my suggestions
amychisholm03
force-pushed
the
NR-4083/source-mapping
branch
from
July 9, 2026 17:22
39b9abc to
50cb745
Compare
bizob2828
requested changes
Jul 9, 2026
bizob2828
left a comment
bizob2828
left a comment
Member
There was a problem hiding this comment.
a few tests suggestions/questions but the code looks great!
| started = true | ||
| }) | ||
|
|
||
| await new Promise((resolve) => setImmediate(resolve)) |
bizob2828
approved these changes
Jul 9, 2026
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds source code mapping* support for our current
CpuProfiler. When enabled via theprofiling.source_mapping.enabledconfig option, approf.SourceMapperis built once during agent startup by scanning the application root (process.cwd()) for source maps. It's cached on theProfilingManagerand passed into theCpuProfiler's constructor when the profilers are registered. It builds it once at startup, rather than on each profiling cycle, to keep the profiling start/stop path synchronous and avoids re-scanning on every collection. Caching it on the manager also lets the sameSourceMapperbe shared with theHeapProfilerwhen we add heap source mapping later.If the
SourceMapperfails to build (or no source maps are found), the profiler falls back to its original behavior and reports the compiled file/line/code information.*Source code mapping refers to mapping the profiling sample to the pre-compiled code e.g. TypeScript, pre-compiled JavaScript. The goal is that users will be able to more easily correlate the node in the flamegraph with the function information (file location, code line number, etc.) in their written code instead of the compiled version.
How to Test
With the example app: newrelic/newrelic-node-examples#378
Related Issues
Closes #4083