fix: Add fallback for contentBitrate and convert adBitrate from KBPS to BPS#118
Closed
avinash-newrelic wants to merge 1 commit intomasterfrom
Closed
fix: Add fallback for contentBitrate and convert adBitrate from KBPS to BPS#118avinash-newrelic wants to merge 1 commit intomasterfrom
avinash-newrelic wants to merge 1 commit intomasterfrom
Conversation
ametku
requested changes
Apr 21, 2026
| // Use actual video bitrate from player's video format instead of download speed | ||
| if (player != null && player.getVideoFormat() != null && player.getVideoFormat().bitrate != C.INDEX_UNSET) { | ||
| this.actualBitrate = player.getVideoFormat().bitrate; | ||
| } else { |
Contributor
There was a problem hiding this comment.
@avinash-newrelic @mlychndnnr this PR needs to merged to a release branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentBitratewas always reported as 0 when manifest-declared bitrate was unavailable. Added a fallback to calculate bitrate from actual download data.adBitratewas incorrectly reported in KBPS instead of BPS. Applied conversion (×1000) to match the data model specification.Changes
player.getVideoFormat().bitrateis unavailablegetVastMediaBitrate()by 1000 to convert KBPS to BPSTest Plan
contentBitratereports a non-zero value in BPSadBitratereports in BPS (e.g., 500000 instead of 500)