Fix PR contract for Dependabot maintenance PRs#232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231\n\n## Summary\n- Extract PR contract logic into scripts/check-pr-contract.sh.\n- Exempt dependency-maintenance Dependabot PRs from the human/agent body prose contract while preserving source-code test requirements.\n- Add scripts/test-pr-contract.sh regression coverage for human, Dependabot, and agent branch cases.\n\n## Tests\n- bash -n scripts/check-pr-contract.sh scripts/test-pr-contract.sh\n- scripts/test-pr-contract.sh\n- Dry-run scripts/check-pr-contract.sh with PR #216 real body/files\n- npm run format:check\n- npm run lint\n- npm run typecheck\n- git diff --check\n- commit pre-commit hook: lint, typecheck, npm run test:unit, npm run format:check\n\n## Notes\n- npm ci completed; npm audit reports existing dependency vulnerabilities unrelated to this workflow/script change.\n