delete_packet_filters -> Delete Bearer via async Gx CCR-U (#22 Increment 2) - #52
Closed
next-nf wants to merge 5 commits into
Closed
delete_packet_filters -> Delete Bearer via async Gx CCR-U (#22 Increment 2)#52next-nf wants to merge 5 commits into
next-nf wants to merge 5 commits into
Conversation
This was referenced Jul 21, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #49 (base
async-ue-bearer-22). Second increment of #22 (UE-requested bearer resource modification).Turns a UE Bearer Resource Command carrying
delete_packet_filtersinto the first real diameter-asyncasync_mprocedure: report the removed SDF filters to the PCRF over a Gx CCR-Update,awaitthe reply non-blockingly, apply the PCC delta, and when the bearer's last rule is gone run the single-bearer deactivation echoing the PTI. On reject → Bearer Resource Failure Indication.Commits
Packet-Filter-Operation/Packet-Filter-Informationin the Gx CCR (DELETE shape: operation + identifiers only, per TS 29.212 §4.5.2)smf_tft:pf_ids_to_sdf/2reverse lookup — inverts#ded_bearer.sdf_to_pf, fails loud on a non-injective map or unknown id (never guesses)delete_packet_filtersreject-arm rewire +smf_aaa_pcf:merge_ctx/2{'$reply'}while an async procedure is parked — closes apcf/aaa_sessionwrite-back race (an early Step-5 gate refinement)Design notes
smf_gsn_lib:detect_removed_bearers/3(the PCRF's rule decision governs), not from the TAD op.fold_cca's stripped#pcf_ctx{}(app_id=undefined) is merged viamerge_ctx/2, never wholesale-replaced (would break the next CCR-U).Tests
pgw_SUITE129/129 (2 new e2e cases: delete → one Delete Bearer echoing the PTI; reject → Failure Indication).diameter_Gx_SUITE7/7,smf_tft_SUITE25/25. Default compile green.Out of scope (Increment 3)
The Update-TFT outcome + PTI Update emitter + uplink-filter guarantee;
add/replace; requested-QoS.Follow-ups
handle_ccabadrecords on itsundefinedstate); the reject case substitutes an unknown-filter trigger exercising the samebr_delete_errpath.handle_ctx_error/4don't drainasync_pending; unreachable today, doesn't affect this PR (br_delete_errdrains correctly).