replace_packet_filters via async Gx CCR-U MODIFICATION (#22 Increment 5) - #55
Closed
next-nf wants to merge 1 commit into
Closed
replace_packet_filters via async Gx CCR-U MODIFICATION (#22 Increment 5)#55next-nf wants to merge 1 commit into
next-nf wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #54 (base
async-ue-bearer-22-inc4). Fifth increment of #22.Handles a UE
replace_packet_filtersBearer Resource Command: report each replaced filter to the PCRF as a Gx CCR-UpdateMODIFICATION(naming the existing filter's SDF handle + carrying its new content), await the rule change, and emit a PTI-echoing Update Bearer Request with the changed TFT — replacing thetrue ->rejectreplace_packet_filtershit before.A delete/add hybrid — almost all reuse
MODIFICATIONis the correct (and only single-message) encoding: a CCR-U'sPacket-Filter-Operationis message-level, so delete+add can't coexist in one message; the grouped AVP carriesPacket-Filter-Identifier(WHICH filter) +Packet-Filter-Content(the NEW value) together.smf_tft:flow_info_to_pf_modify_group/2= the Inc4 ADD content group plus aPacket-Filter-Identifier(the SDF handle, from invertingsdf_to_pf). With adiameter_Gx_SUITEwire round-trip confirming id + content coexist on the wire.ue_replace_filters_proc/4— delete's reverse-lookup (pf_ids_to_sdf+zip), add's content,MODIFICATIONop,remove+installfold, and the sharedue_delete_outcomebranch (empty → Delete edge / non-empty → Update). Reusesemit_ue_update_bearer/await_pfcp_modify/detect_modified_bearers/ue_update_outcome/br_ok/br_err/ccr_result/fold_ccaverbatim.Tests
pgw_SUITE132/132 (131 prior + 1 new: one-filter bearer → replace with new content → one Update Bearer Request echoing the PTI carrying the changed, still-one-filter TFT; the delete/add regression stays green).smf_tft_SUITE(modify-group unit),diameter_Gx_SUITE9/9 (MODIFICATION round-trip). Default compile green.Charging-Rule-Namereinstall with changedFlow-Informationsurfaces a TFT delta throughgx_events_to_pcc_ctx(install)sodetect_modified_bearersfires — is empirically confirmed by the passing e2e (the Update Bearer only fires if the fold saw the change).Note
Executed inline (authored directly, comprehensive tests, no separate implementer/reviewer subagent — unlike Inc2–4).
Out of scope
Requested-QoS/GBR change (Increment 6). A replace whose PCRF response binds a new
{QCI,ARP}— out of scope; the branch acks gracefully.