fix the OTP activation snippet in CLAUDE.md - #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The activation snippet in
CLAUDE.mdsilently does nothing.kerl list installationsnames the OTP 28.3 install28.3, nototp-28.3:So
/^otp-28\.3 /matches no line,$(...)expands to empty, and the commanddegrades to
. /activate— which fails and leaves whatever OTP is onPATHactive. Builds still pass, because the default OTP happens to be usable, which
is exactly why this went unnoticed.
Changing the pattern to
/^28\.3 /makes it resolve. Verified after the fix:Note the install name is a local kerl choice rather than something the repo
controls, so on a machine where the 28.3 install is named
otp-28.3the oldpattern is the correct one. If that split turns out to matter across the team,
a pattern matching both (e.g.
/^(otp-)?28\.3 /) would be the more portablefix — happy to switch to that instead.
Based on
main, independent of the async stack (#45 → #67). Heads-up: #45 addsa section immediately after this code block, so rebasing that stack onto a
maincontaining this commit may flag a trivial overlap there; the resolution is to
keep both changes.