drop stale #22 TODO references - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22 is closed (all its increments landed via #56/#57/#58), but two comments still referred to it as pending work:
pgw_s5s8.erl:1183carried a literalTODO(#22)token inside prose that was actually recording the deferral's closure — so it showed up in any grep for outstanding TODOs.smf_tft.erl:333said "document/assert uniqueness when PGW: implement UE-requested bearer resource modification (TAD add/replace/delete) #22 consumes it". It consumes it now, viapf_ids_to_sdf/2, so the future tense was wrong. TheTODO(#32)on that line stays — the duplicate-identifier overwrite is still real and still open — but it now states why the uniqueness assumption is load-bearing rather than deferring the question.No behaviour change; comments only.
grep -rn "TODO(#22)" apps/is now empty. The remaining#22mentions (pgw_s5s8.erllines 516, 517, 532, 546, 562, 1158, 1199, 1230, 1259) are provenance annotations — "#22 Inc4" and the like — and are worth keeping.