feat: Implement memories

[marcelklehr]

Depends on

• feat: Implement optional input slots for chat memories integration_openai#310
• feat(chat): Add optional memories input for core:text2text:chat llm2#158
• feat: Add optional memories input slot context_agent#93

But is backward compatible

• Toggle in the chat
• Memories overview in the personal settings
• Design review
• Turn button into toggle and make toggle disappear in 3dot menu on small screens
• Don't load full sessions in setting page (because conversation_token is quite large)

[julien-nc]

So we need something in the frontend to toggle is_remembered for a session, right?

[julien-nc]

I hope you don't mind, I pushed a few commits to fix a typo and adjust the "update chat session" controller method.

[janepie]

So we need something in the frontend to toggle is_remembered for a session, right?

Added, but it doesn't end up in the db, any idea why?

[marcelklehr]

Can you push your code?

[marcelklehr]

[marcoambrosini]

Nice that you've been able to do it like this in the end!

I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton type="radio". It basically can behave like a switch

Screen.Recording.2025-12-16.at.16.14.16.mov

For the action icon I think it's fine to use this

[janepie]

I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton

Feels like no one will ever see or use this then

[julien-nc]

I hope you don't mind me pushing here. @janepie and me found out the custom setter was the issue. It somehow changes 0 to '' when updating the entity. It works fine with the magic setter method.

[marcelklehr]

I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton

Feels like no one will ever see or use this then

mmh, I sort of agree. Hiding it in the ... menu makes it less likely for people to discover it :/

[marcoambrosini]

Feels like no one will ever see or use this then

Copying from internal chat on the topic:
From my PoV it's ok. We also have not tested the usefulness of of this in the real world so I would prefer a conservative approach of having it behind a menu until we know it's really good and useful. We can always pop it out of the action menu as an unlabelled (or even labelled) button if we get lots of requests or when the feature is more mature.

[janepie]

Added a summary list in the personal settings

[janepie]

We also have not tested the usefulness of of this in the real world so I would prefer a conservative approach of having it behind a menu until we know it's really good and useful. We can always pop it out of the action menu as an unlabelled (or even labelled) button if we get lots of requests or when the feature is more mature.

@marcoambrosini We develop it for people to use it and we want it to be seen and used. Do you have any proposal for a location that is less "disruptive" and still visible?

I changed the icon to the memory one (like that!), as it doesn't have a filled version I adapted the text to change to Remembered when clicked, wdyt?

[julien-nc]

Maybe a tradeoff would be to make the button "icon-only" (with the label becoming the html title) and add a NcActionCheclbox item in the dropdown menu.

[janepie]

New proposal by @nimishavijay : make it a toggle instead of a primary button so it's less "big block"

[kyteinsky]

maybe it would be nicer to indicate the metadata part

Suggested change

	* Update session
	*
	* @param integer $sessionId The chat session ID
	* @param string|null $title The new chat session title
	* @param bool|null $is_remembered The new is_remembered status: Whether to remember the insights from this chat session across all chat session
	* @return JSONResponse<Http::STATUS_OK, list{}, array{}>|JSONResponse<Http::STATUS_INTERNAL_SERVER_ERROR|Http::STATUS_NOT_FOUND, array{error: string}, array{}>
	*
	* 200: The title has been updated successfully
	* 404: The session was not found
	*/
	#[NoAdminRequired]
	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT, tags: ['chat_api'])]
	public function updateChatSession(int $sessionId, ?string $title = null, ?bool $is_remembered = null): JSONResponse {
	* Update session's metadata
	*
	* @param integer $sessionId The chat session ID
	* @param string|null $title The new chat session title
	* @param bool|null $is_remembered The new is_remembered status: Whether to remember the insights from this chat session across all chat session
	* @return JSONResponse<Http::STATUS_OK, list{}, array{}>|JSONResponse<Http::STATUS_INTERNAL_SERVER_ERROR|Http::STATUS_NOT_FOUND, array{error: string}, array{}>
	*
	* 200: Metaadata of the session has been updated successfully
	* 404: The session was not found
	*/
	#[NoAdminRequired]
	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT, tags: ['chat_api'])]
	public function updateChatSessionMetadata(int $sessionId, ?string $title = null, ?bool $is_remembered = null): JSONResponse {

[marcelklehr]

I think with the available params, it's kinda self explanatory, no?

[kyteinsky]

yeah but does require a little more effort to parse since updaing a session could also refer to message addition/deletion in that session.

[kyteinsky]

Suggested change

	async updateSession() {
	async updateSessionMetadata() {

if the change in the controller is done

[marcoambrosini]

We develop it for people to use it and we want it to be seen and used. Do you have any proposal for a location that is less "disruptive" and still visible?

I'm ok with @nimishavijay suggestion as long as this action gets pushed into the menu on narrow screens.